athena/home/minimized_home.h - Issue 478293004: Refactor the home card structure and introduce animation.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: athena/home/minimized_home.h

Issue 478293004: Refactor the home card structure and introduce animation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rease Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef ATHENA_HOME_MINIMIZED_HOME_H_	5 #ifndef ATHENA_HOME_MINIMIZED_HOME_H_

6 #define ATHENA_HOME_MINIMIZED_HOME_H_	6 #define ATHENA_HOME_MINIMIZED_HOME_H_

7	7

8 namespace views {	8 #include "base/memory/scoped_ptr.h"

9 class View;	9

	10 namespace ui {

	11 class LayerOwner;

10 }	12 }

11	13

12 namespace athena {	14 namespace athena {

13	15

14 views::View* CreateMinimizedHome();	16 scoped_ptr<ui::LayerOwner> CreateMinimizedHome();
	sadrul 2014/08/26 15:47:26 I think you should just return a Layer here. I think you should just return a Layer here. Jun Mukai 2014/08/26 17:21:33 I need the LayerDelegate to draw the content of mi Show quoted text On 2014/08/26 15:47:26, sadrul wrote: > I think you should just return a Layer here. I need the LayerDelegate to draw the content of minimized home, and the layer delegate needs to be owned by someone else. Thus I created the minimized home layer and then returns its owner (which is actually the LayerDelegate), and caller will own both the layer and the delegate. Do you think this needs to be fixed? It seems doing similarly as aura::Window. As I reviewed aura::Window interface, I found ignore_events() field. This could be implemented by aura::Window with ignore_events field. sadrul 2014/08/26 20:11:18 Ah, I see. Show quoted text On 2014/08/26 17:21:33, Jun Mukai wrote: > On 2014/08/26 15:47:26, sadrul wrote: > > I think you should just return a Layer here. > > I need the LayerDelegate to draw the content of minimized home, and the layer > delegate needs to be owned by someone else. Thus I created the minimized home > layer and then returns its owner (which is actually the LayerDelegate), and > caller will own both the layer and the delegate. Ah, I see. Show quoted text > > Do you think this needs to be fixed? It seems doing similarly as aura::Window. > As I reviewed aura::Window interface, I found ignore_events() field. This could > be implemented by aura::Window with ignore_events field.
15	17

16 } // namespace athena	18 } // namespace athena

17	19

18 #endif // ATHENA_HOME_MINIMIZED_HOME_H_	20 #endif // ATHENA_HOME_MINIMIZED_HOME_H_

OLD	NEW

« no previous file with comments | « athena/home/home_card_impl.cc ('k') | athena/home/minimized_home.cc » ('j') | athena/home/minimized_home.cc » ('J')