Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 478293004: Refactor the home card structure and introduce animation. (Closed)

Created:
6 years, 4 months ago by Jun Mukai
Modified:
6 years, 3 months ago
Reviewers:
sadrul
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Refactor the home card structure and introduce animation. This CL includes the following refactorings: - minimized home is simply a layer instead of views - moves the mouse click handler of minimized home to home card impl - home card now has the same size of the screen. Changing state is now simply changing its position. Then schedule the animation between BOTTOM state and CENTERED state. BUG=398062 R=sadrul@chromium.org, oshima@chromium.org TEST=manually on remote desktop Committed: https://crrev.com/30e0231395281e1275f0ebfd09b31605a2ecf4cd Cr-Commit-Position: refs/heads/master@{#292092}

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : cleanup #

Patch Set 4 : strip includes #

Patch Set 5 : screen rotation fix #

Patch Set 6 : background layer #

Patch Set 7 : rebase #

Patch Set 8 : rease #

Total comments: 5

Patch Set 9 : rebase #

Patch Set 10 : fix #

Total comments: 2

Patch Set 11 : rebase #

Patch Set 12 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+274 lines, -195 lines) Patch
M athena/home/athena_start_page_view.h View 1 2 3 4 5 3 chunks +34 lines, -2 lines 0 comments Download
M athena/home/athena_start_page_view.cc View 1 2 3 4 5 6 7 8 9 10 6 chunks +115 lines, -62 lines 0 comments Download
M athena/home/home_card_gesture_manager.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -0 lines 0 comments Download
M athena/home/home_card_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 18 chunks +95 lines, -100 lines 0 comments Download
M athena/home/minimized_home.h View 1 chunk +5 lines, -3 lines 0 comments Download
M athena/home/minimized_home.cc View 1 2 3 4 5 6 7 8 9 2 chunks +24 lines, -28 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
Jun Mukai
6 years, 4 months ago (2014-08-21 20:23:06 UTC) #1
sadrul
Quick question: > - home card now has the same size of the screen. Changing ...
6 years, 4 months ago (2014-08-21 21:30:30 UTC) #2
Jun Mukai
On 2014/08/21 21:30:30, sadrul wrote: > Quick question: > > > - home card now ...
6 years, 4 months ago (2014-08-21 21:34:33 UTC) #3
oshima
sadrul's review will be enough. removing myself.
6 years, 4 months ago (2014-08-21 22:58:34 UTC) #4
Jun Mukai
Noticed this CL doesn't work well with screen rotation because minimized home is not repositioned. ...
6 years, 4 months ago (2014-08-21 23:00:34 UTC) #5
Jun Mukai
sadrul, could you review this?
6 years, 4 months ago (2014-08-22 19:50:52 UTC) #6
Jun Mukai
noticed that SchedulePaint() at Layout() makes the animation laggy, so added another layer for the ...
6 years, 4 months ago (2014-08-22 22:25:30 UTC) #7
Jun Mukai
Sadrul, can you take a look at this CL?
6 years, 4 months ago (2014-08-25 18:17:37 UTC) #8
sadrul
https://codereview.chromium.org/478293004/diff/140001/athena/home/minimized_home.cc File athena/home/minimized_home.cc (right): https://codereview.chromium.org/478293004/diff/140001/athena/home/minimized_home.cc#newcode20 athena/home/minimized_home.cc:20: MinimizedHomePainter(ui::Layer* layer) { explicit https://codereview.chromium.org/478293004/diff/140001/athena/home/minimized_home.h File athena/home/minimized_home.h (right): https://codereview.chromium.org/478293004/diff/140001/athena/home/minimized_home.h#newcode16 ...
6 years, 3 months ago (2014-08-26 15:47:26 UTC) #9
Jun Mukai
https://codereview.chromium.org/478293004/diff/140001/athena/home/minimized_home.cc File athena/home/minimized_home.cc (right): https://codereview.chromium.org/478293004/diff/140001/athena/home/minimized_home.cc#newcode20 athena/home/minimized_home.cc:20: MinimizedHomePainter(ui::Layer* layer) { On 2014/08/26 15:47:26, sadrul wrote: > ...
6 years, 3 months ago (2014-08-26 17:21:33 UTC) #10
sadrul
LGTM https://codereview.chromium.org/478293004/diff/140001/athena/home/minimized_home.h File athena/home/minimized_home.h (right): https://codereview.chromium.org/478293004/diff/140001/athena/home/minimized_home.h#newcode16 athena/home/minimized_home.h:16: scoped_ptr<ui::LayerOwner> CreateMinimizedHome(); On 2014/08/26 17:21:33, Jun Mukai wrote: ...
6 years, 3 months ago (2014-08-26 20:11:18 UTC) #11
Jun Mukai
https://codereview.chromium.org/478293004/diff/180001/athena/home/home_card_impl.cc File athena/home/home_card_impl.cc (right): https://codereview.chromium.org/478293004/diff/180001/athena/home/home_card_impl.cc#newcode74 athena/home/home_card_impl.cc:74: explicit HomeCardLayoutManager() On 2014/08/26 20:11:18, sadrul wrote: > You ...
6 years, 3 months ago (2014-08-26 20:48:45 UTC) #12
Jun Mukai
The CQ bit was checked by mukai@chromium.org
6 years, 3 months ago (2014-08-26 20:48:56 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/478293004/220001
6 years, 3 months ago (2014-08-26 20:50:13 UTC) #14
commit-bot: I haz the power
Committed patchset #12 (220001) as e205d4af6e1dc98aad72b6dbdda62929d18c62c2
6 years, 3 months ago (2014-08-27 03:37:33 UTC) #15
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:49:34 UTC) #16
Message was sent while issue was closed.
Patchset 12 (id:??) landed as
https://crrev.com/30e0231395281e1275f0ebfd09b31605a2ecf4cd
Cr-Commit-Position: refs/heads/master@{#292092}

Powered by Google App Engine
This is Rietveld 408576698