LayoutTests/css3/flexbox/flex-property-parsing.html - Issue 478233004: Flexbox flex: 1 incorrectly sets flex-basis to 0px

Unified Diff: LayoutTests/css3/flexbox/flex-property-parsing.html

Issue 478233004: Flexbox flex: 1 incorrectly sets flex-basis to 0px (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/css3/flexbox/flex-one-sets-flex-basis-to-zero-px-expected.txt ('k') | LayoutTests/css3/flexbox/flex-property-parsing-expected.txt » ('j') | Source/core/rendering/RenderFlexibleBox.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/css3/flexbox/flex-property-parsing.html

diff --git a/LayoutTests/css3/flexbox/flex-property-parsing.html b/LayoutTests/css3/flexbox/flex-property-parsing.html

index a1cdef2dc1c712188e501ded2b7da3bad68e84e2..a216fb4fa4fdb6aa600a087fa48243655ed91d97 100644

--- a/LayoutTests/css3/flexbox/flex-property-parsing.html

+++ b/LayoutTests/css3/flexbox/flex-property-parsing.html

@@ -28,16 +28,16 @@ shouldBeEqualToString('flexitem.style.webkitFlex', '');

shouldBeEqualToString('getComputedStyle(flexitem).webkitFlex', '0 1 auto');

flexitem.style.webkitFlex = '2';

-shouldBeEqualToString('flexitem.style.webkitFlex', '2 1 0px');

-shouldBeEqualToString('getComputedStyle(flexitem).webkitFlex', '2 1 0px');

+shouldBeEqualToString('flexitem.style.webkitFlex', '2 1 0%');

+shouldBeEqualToString('getComputedStyle(flexitem).webkitFlex', '2 1 0%');

flexitem.style.webkitFlex = '0';

-shouldBeEqualToString('flexitem.style.webkitFlex', '0 1 0px');

-shouldBeEqualToString('getComputedStyle(flexitem).webkitFlex', '0 1 0px');

+shouldBeEqualToString('flexitem.style.webkitFlex', '0 1 0%');

+shouldBeEqualToString('getComputedStyle(flexitem).webkitFlex', '0 1 0%');

flexitem.style.webkitFlex = '1.5';

-shouldBeEqualToString('flexitem.style.webkitFlex', '1.5 1 0px');

-shouldBeEqualToString('getComputedStyle(flexitem).webkitFlex', '1.5 1 0px');

+shouldBeEqualToString('flexitem.style.webkitFlex', '1.5 1 0%');

+shouldBeEqualToString('getComputedStyle(flexitem).webkitFlex', '1.5 1 0%');

flexitem.style.webkitFlex = 'auto';

shouldBeEqualToString('flexitem.style.webkitFlex', '1 1 auto');

@@ -61,16 +61,16 @@ shouldBeEqualToString('flexitem.style.webkitFlex', '0 0 auto');

shouldBeEqualToString('getComputedStyle(flexitem).webkitFlex', '0 0 auto');

flexitem.style.webkitFlex = '0 0';

-shouldBeEqualToString('flexitem.style.webkitFlex', '0 0 0px');

-shouldBeEqualToString('getComputedStyle(flexitem).webkitFlex', '0 0 0px');

+shouldBeEqualToString('flexitem.style.webkitFlex', '0 0 0%');

+shouldBeEqualToString('getComputedStyle(flexitem).webkitFlex', '0 0 0%');

flexitem.style.webkitFlex = '0 1';

-shouldBeEqualToString('flexitem.style.webkitFlex', '0 1 0px');

-shouldBeEqualToString('getComputedStyle(flexitem).webkitFlex', '0 1 0px');

+shouldBeEqualToString('flexitem.style.webkitFlex', '0 1 0%');

+shouldBeEqualToString('getComputedStyle(flexitem).webkitFlex', '0 1 0%');

flexitem.style.webkitFlex = '1 0';

-shouldBeEqualToString('flexitem.style.webkitFlex', '1 0 0px');

-shouldBeEqualToString('getComputedStyle(flexitem).webkitFlex', '1 0 0px');

+shouldBeEqualToString('flexitem.style.webkitFlex', '1 0 0%');

+shouldBeEqualToString('getComputedStyle(flexitem).webkitFlex', '1 0 0%');

flexitem.style.webkitFlex = '2 auto';

shouldBeEqualToString('flexitem.style.webkitFlex', '2 1 auto');