LayoutTests/css3/flexbox/flex-longhand-parsing.html - Issue 478233004: Flexbox flex: 1 incorrectly sets flex-basis to 0px

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/css3/flexbox/flex-longhand-parsing.html

Issue 478233004: Flexbox flex: 1 incorrectly sets flex-basis to 0px (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <script src="../../resources/js-test.js"></script>	4 <script src="../../resources/js-test.js"></script>

5 </head>	5 </head>

6 <body>	6 <body>

7 <div id="flexbox">	7 <div id="flexbox">

8 <div id="flexitem"></div>	8 <div id="flexitem"></div>

9 </div>	9 </div>

10 <script>	10 <script>

(...skipping 38 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
49 shouldBeEqualToString('flexitem.style.webkitFlexGrow', '0');	49 shouldBeEqualToString('flexitem.style.webkitFlexGrow', '0');

50 shouldBeEqualToString('flexitem.style.webkitFlexShrink', '0');	50 shouldBeEqualToString('flexitem.style.webkitFlexShrink', '0');

51 shouldBeEqualToString('flexitem.style.webkitFlexBasis', 'auto');	51 shouldBeEqualToString('flexitem.style.webkitFlexBasis', 'auto');

52 shouldBeEqualToString('getComputedStyle(flexitem).webkitFlex', '0 0 auto');	52 shouldBeEqualToString('getComputedStyle(flexitem).webkitFlex', '0 0 auto');

53	53

54 flexitem.style.webkitFlexGrow = 1.5;	54 flexitem.style.webkitFlexGrow = 1.5;

55 shouldBeEqualToString('flexitem.style.webkitFlex', '1.5 0 auto');	55 shouldBeEqualToString('flexitem.style.webkitFlex', '1.5 0 auto');

56 shouldBeEqualToString('getComputedStyle(flexitem).webkitFlex', '1.5 0 auto');	56 shouldBeEqualToString('getComputedStyle(flexitem).webkitFlex', '1.5 0 auto');

57	57

58 flexitem.style.webkitFlex = 3;	58 flexitem.style.webkitFlex = 3;

59 shouldBeEqualToString('flexitem.style.webkitFlex', '3 1 0px');	59 shouldBeEqualToString('flexitem.style.webkitFlex', '3 1 0%');

60 shouldBeEqualToString('flexitem.style.webkitFlexGrow', '3');	60 shouldBeEqualToString('flexitem.style.webkitFlexGrow', '3');

61 shouldBeEqualToString('flexitem.style.webkitFlexShrink', '1');	61 shouldBeEqualToString('flexitem.style.webkitFlexShrink', '1');

62 shouldBeEqualToString('flexitem.style.webkitFlexBasis', '0px');	62 shouldBeEqualToString('flexitem.style.webkitFlexBasis', '0%');

63 shouldBeEqualToString('getComputedStyle(flexitem).webkitFlex', '3 1 0px');	63 shouldBeEqualToString('getComputedStyle(flexitem).webkitFlex', '3 1 0%');

64	64

65 </script>	65 </script>

66 </body>	66 </body>

67 </html>	67 </html>

OLD	NEW

« no previous file with comments | « LayoutTests/css3/calc/number-parsing.html ('k') | LayoutTests/css3/flexbox/flex-longhand-parsing-expected.txt » ('j') | no next file with comments »