Issue 478233003: Make some ScriptValue references const

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 478233003: Make some ScriptValue references const (Closed)

Created:
6 years, 4 months ago by Jens Widell

Modified:
6 years, 4 months ago

Reviewers:
dominicc (has gone to gerrit)

CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, serviceworker-reviews, tzik, blink-reviews-css, horo+watch_chromium.org, ed+blinkwatch_opera.com, nhiroki, falken, dglazkov+blink, apavlov+blink_chromium.org, darktears, kinuko+serviceworker, rune+blink, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Make some ScriptValue references const The functions FontFaceSet::forEach() and Headers::forEach() are called from the bindings layer, and by having non-const reference arguments, they somewhat restrict what we can do in the bindings layer. Since there is no reason for the arguments to be non-const references, just make them const. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180719

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -8 lines)			Patch
M	Source/core/css/FontFaceSet.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/css/FontFaceSet.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/modules/serviceworkers/Headers.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/modules/serviceworkers/Headers.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

dominicc (has gone to gerrit)

The CQ bit was checked by dominicc@chromium.org

6 years, 4 months ago (2014-08-21 08:58:43 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jl@opera.com/478233003/1

6 years, 4 months ago (2014-08-21 08:59:49 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (1) as 180719

Expand Messages | Collapse Messages