Issue 478233002: [arm] Recognize comparisons of shifts with zero.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 478233002: [arm] Recognize comparisons of shifts with zero. (Closed)

Created:
6 years, 4 months ago by Benedikt Meurer

Modified:
6 years, 4 months ago

Reviewers:
Jarin

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

[arm] Recognize comparisons of shifts with zero. For example, recognize 0 == r1 << r2 and generate a single MOVS rt, r1, lsl r2 instruction. TEST=cctest,compiler-unittests R=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23148

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+295 lines, -11 lines)			Patch
M	src/arm/macro-assembler-arm.h	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	src/compiler/arm/code-generator-arm.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/compiler/arm/instruction-selector-arm.cc	View	2 chunks	+44 lines, -7 lines	0 comments	Download
M	test/cctest/compiler/test-run-machops.cc	View	4 chunks	+208 lines, -0 lines	0 comments	Download
M	test/compiler-unittests/arm/instruction-selector-arm-unittest.cc	View	1 chunk	+37 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

Benedikt Meurer

6 years, 4 months ago (2014-08-18 11:10:11 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as 23148 (tree was closed).