Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Unified Diff: printing/printing_context_no_system_dialog.cc

Issue 47823002: De-duplicate job_settings parsing code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Noam's comments Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « printing/printing_context_no_system_dialog.h ('k') | printing/printing_context_win.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: printing/printing_context_no_system_dialog.cc
diff --git a/printing/printing_context_no_system_dialog.cc b/printing/printing_context_no_system_dialog.cc
index f02ef329ad0dcdba86290d86f75f5e2aee16ac71..7fd2ceebeb7d0f31e6c8e053a6a88f4e7459a439 100644
--- a/printing/printing_context_no_system_dialog.cc
+++ b/printing/printing_context_no_system_dialog.cc
@@ -73,24 +73,14 @@ PrintingContext::Result PrintingContextNoSystemDialog::UseDefaultSettings() {
settings_.set_dpi(dpi);
settings_.SetPrinterPrintableArea(physical_size_device_units,
printable_area_device_units,
- dpi);
+ dpi, true);
return OK;
}
PrintingContext::Result PrintingContextNoSystemDialog::UpdatePrinterSettings(
- const base::DictionaryValue& job_settings, const PageRanges& ranges) {
- bool landscape = false;
-
- if (!job_settings.GetBoolean(kSettingLandscape, &landscape))
- return OnError();
-
- if (settings_.dpi() == 0)
- UseDefaultSettings();
-
- settings_.SetOrientation(landscape);
- settings_.ranges = ranges;
-
+ bool target_is_pdf,
+ bool external_preview) {
return OK;
}
« no previous file with comments | « printing/printing_context_no_system_dialog.h ('k') | printing/printing_context_win.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698