Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(719)

Unified Diff: printing/printing_context_mac.h

Issue 47823002: De-duplicate job_settings parsing code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Noam's comments Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « printing/printing_context_gtk.cc ('k') | printing/printing_context_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: printing/printing_context_mac.h
diff --git a/printing/printing_context_mac.h b/printing/printing_context_mac.h
index 8dc70ba39e30a3475705550fe1e18ae23296b9b6..8e7e51082d7eccd0d0277bfd10f2b453bcd91309 100644
--- a/printing/printing_context_mac.h
+++ b/printing/printing_context_mac.h
@@ -31,9 +31,8 @@ class PRINTING_EXPORT PrintingContextMac : public PrintingContext {
bool has_selection,
const PrintSettingsCallback& callback) OVERRIDE;
virtual Result UseDefaultSettings() OVERRIDE;
- virtual Result UpdatePrinterSettings(
- const base::DictionaryValue& job_settings,
- const PageRanges& ranges) OVERRIDE;
+ virtual Result UpdatePrinterSettings(bool target_is_pdf,
+ bool external_preview) OVERRIDE;
virtual Result InitWithSettings(const PrintSettings& settings) OVERRIDE;
virtual Result NewDocument(const base::string16& document_name) OVERRIDE;
virtual Result NewPage() OVERRIDE;
@@ -48,8 +47,8 @@ class PRINTING_EXPORT PrintingContextMac : public PrintingContext {
// after changes to |print_info_| in order for the changes to take effect in
// printing.
// This function ignores the page range information specified in the print
- // info object and use |ranges| instead.
- void InitPrintSettingsFromPrintInfo(const PageRanges& ranges);
+ // info object and use |settings_.ranges| instead.
+ void InitPrintSettingsFromPrintInfo();
// Returns the set of page ranges constructed from |print_info_|.
PageRanges GetPageRangesFromPrintInfo();
« no previous file with comments | « printing/printing_context_gtk.cc ('k') | printing/printing_context_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698