printing/printing_context_android.h - Issue 47823002: De-duplicate job_settings parsing code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: printing/printing_context_android.h

Issue 47823002: De-duplicate job_settings parsing code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Noam's comments Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: printing/printing_context_android.h

diff --git a/printing/printing_context_android.h b/printing/printing_context_android.h

index ff0d222273e693b58054d39aafd090bbfdf7fc9b..67d68eb40ded6573565d94fa1d95b687391dc1ed 100644

--- a/printing/printing_context_android.h

+++ b/printing/printing_context_android.h

@@ -37,9 +37,8 @@ class PRINTING_EXPORT PrintingContextAndroid : public PrintingContext {

bool has_selection,

const PrintSettingsCallback& callback) OVERRIDE;

virtual Result UseDefaultSettings() OVERRIDE;

- virtual Result UpdatePrinterSettings(

- const base::DictionaryValue& job_settings,

- const PageRanges& ranges) OVERRIDE;

+ virtual Result UpdatePrinterSettings(bool target_is_pdf,

+ bool external_preview) OVERRIDE;

virtual Result InitWithSettings(const PrintSettings& settings) OVERRIDE;

virtual Result NewDocument(const base::string16& document_name) OVERRIDE;

virtual Result NewPage() OVERRIDE;

« no previous file with comments | « printing/printing_context.cc ('k') | printing/printing_context_gtk.h » ('j') | no next file with comments »