Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Unified Diff: printing/printing_context.h

Issue 47823002: De-duplicate job_settings parsing code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Noam's comments Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « printing/printed_document.cc ('k') | printing/printing_context.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: printing/printing_context.h
diff --git a/printing/printing_context.h b/printing/printing_context.h
index f4ba7ad759d4b7bfb59d12cc2361d05f350ec31f..3bd7ba5cd5ba4f759d60520979a1b5a22c65e52a 100644
--- a/printing/printing_context.h
+++ b/printing/printing_context.h
@@ -51,11 +51,14 @@ class PRINTING_EXPORT PrintingContext {
// default device settings.
virtual Result UseDefaultSettings() = 0;
- // Updates printer related settings. |job_settings| contains all print job
- // settings information. |ranges| has the new page range settings.
- virtual Result UpdatePrinterSettings(
- const base::DictionaryValue& job_settings,
- const PageRanges& ranges) = 0;
+ // Updates printer settings.
+ // |pdf_only| is true if implementation needs to generate PDF without actual
+ // printing. In this case implementation may avoid setup of native print
+ // system. Ex. "save to pdf" or Cloud Print.
+ // |external_preview| is true if pdf is going to be opened in external
+ // preview.
+ virtual Result UpdatePrinterSettings(bool target_is_pdf,
+ bool external_preview) = 0;
// Updates Print Settings. |job_settings| contains all print job
// settings information. |ranges| has the new page range settings.
« no previous file with comments | « printing/printed_document.cc ('k') | printing/printing_context.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698