Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Unified Diff: printing/print_settings_initializer_mac.cc

Issue 47823002: De-duplicate job_settings parsing code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Noam's comments Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « printing/print_settings_initializer_mac.h ('k') | printing/print_settings_initializer_win.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: printing/print_settings_initializer_mac.cc
diff --git a/printing/print_settings_initializer_mac.cc b/printing/print_settings_initializer_mac.cc
index e6ba4ea37d335961d8d6075ccb191ffabc5cdc93..9333ec9e8b8dd2591566eb319369eaa3e9f63268 100644
--- a/printing/print_settings_initializer_mac.cc
+++ b/printing/print_settings_initializer_mac.cc
@@ -13,19 +13,13 @@ namespace printing {
void PrintSettingsInitializerMac::InitPrintSettings(
PMPrinter printer,
PMPageFormat page_format,
- const PageRanges& new_ranges,
- bool print_selection_only,
PrintSettings* print_settings) {
- DCHECK(print_settings);
-
print_settings->set_device_name(
base::SysCFStringRefToUTF16(PMPrinterGetID(printer)));
- print_settings->ranges = new_ranges;
PMOrientation orientation = kPMPortrait;
PMGetOrientation(page_format, &orientation);
- print_settings->set_landscape(orientation == kPMLandscape);
- print_settings->selection_only = print_selection_only;
+ print_settings->SetOrientation(orientation == kPMLandscape);
UInt32 resolution_count = 0;
PMResolution best_resolution = { 72.0, 72.0 };
@@ -62,7 +56,7 @@ void PrintSettingsInitializerMac::InitPrintSettings(
print_settings->SetPrinterPrintableArea(physical_size_device_units,
printable_area_device_units,
- 72);
+ 72, false);
}
} // namespace printing
« no previous file with comments | « printing/print_settings_initializer_mac.h ('k') | printing/print_settings_initializer_win.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698