printing/print_settings_initializer.h - Issue 47823002: De-duplicate job_settings parsing code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: printing/print_settings_initializer.h

Issue 47823002: De-duplicate job_settings parsing code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Noam's comments Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: printing/print_settings_initializer.h

diff --git a/printing/print_settings_initializer.h b/printing/print_settings_initializer.h

index 4897be87e186bf2bb8c0fd1d05a70be67ba4e7ba..a1093c5a3b8609a93a147329912a525e5f7194ba 100644

--- a/printing/print_settings_initializer.h

+++ b/printing/print_settings_initializer.h

@@ -7,6 +7,7 @@

#include "base/basictypes.h"

#include "base/logging.h"

+#include "printing/page_range.h"

#include "printing/printing_export.h"

namespace base {

@@ -21,8 +22,9 @@ class PrintSettings;

// provided |job_settings|.

class PRINTING_EXPORT PrintSettingsInitializer {

public:

- static void InitHeaderFooterStrings(

+ static bool InitSettings(

const base::DictionaryValue& job_settings,

+ const PageRanges& ranges,

PrintSettings* print_settings);

private:

« no previous file with comments | « printing/print_settings.cc ('k') | printing/print_settings_initializer.cc » ('j') | no next file with comments »