Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3221)

Unified Diff: chrome/browser/printing/print_dialog_gtk.h

Issue 47823002: De-duplicate job_settings parsing code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Noam's comments Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/printing/print_dialog_gtk.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/printing/print_dialog_gtk.h
diff --git a/chrome/browser/printing/print_dialog_gtk.h b/chrome/browser/printing/print_dialog_gtk.h
index 06a14c79be8d7943fc79e27d4b5fb735382d6f45..9c22af480d287b58dc7c80326f9deaf3d54e0532 100644
--- a/chrome/browser/printing/print_dialog_gtk.h
+++ b/chrome/browser/printing/print_dialog_gtk.h
@@ -36,8 +36,7 @@ class PrintDialogGtk
// printing::PrintDialogGtkInterface implementation.
virtual void UseDefaultSettings() OVERRIDE;
- virtual bool UpdateSettings(const base::DictionaryValue& job_settings,
- const printing::PageRanges& ranges,
+ virtual bool UpdateSettings(bool target_is_pdf,
printing::PrintSettings* settings) OVERRIDE;
virtual void ShowDialog(
gfx::NativeView parent_view,
@@ -69,9 +68,8 @@ class PrintDialogGtk
void OnJobCompleted(GtkPrintJob* print_job, GError* error);
// Helper function for initializing |context_|'s PrintSettings with a given
- // set of |page_ranges| and |settings|.
- void InitPrintSettings(const printing::PageRanges& page_ranges,
- printing::PrintSettings* settings);
+ // |settings|.
+ void InitPrintSettings(printing::PrintSettings* settings);
// Printing dialog callback.
PrintingContextGtk::PrintSettingsCallback callback_;
« no previous file with comments | « no previous file | chrome/browser/printing/print_dialog_gtk.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698