De-duplicate job_settings parsing code.

printing/print_job_constants.h

Index: printing/print_job_constants.h
diff --git a/printing/print_job_constants.h b/printing/print_job_constants.h
index c038eb00cbbeaae48202700da31e1a8bd4e36ca1..526f8ee34f8bf79b408aa0126d7ee6922acfeb55 100644
--- a/printing/print_job_constants.h
+++ b/printing/print_job_constants.h
@@ -53,10 +53,7 @@ PRINTING_EXPORT extern const char kSettingShouldPrintSelectionOnly[];
 
 PRINTING_EXPORT extern const int FIRST_PAGE_INDEX;
 PRINTING_EXPORT extern const int COMPLETE_PREVIEW_DOCUMENT_INDEX;
-
-#if defined(OS_MACOSX)

[Noam Samuel, 2013/10/28 21:52:39]

Is "Preview" a reference to print preview, or the application Preview in Mac
OSX?

[Vitaly Buka (NO REVIEWS), 2013/10/28 21:58:10]

Yes. It's MacOSX preview.
I'd like to have code less platform dependent so I remove this ifdef.

On 2013/10/28 21:52:39, Noam Samuel wrote:

[Noam Samuel, 2013/10/28 22:03:01]

Maybe it's worth a comment explaining it? I could guess what it meant based on
the ifdefs, but without them it's not 100% clear.

On 2013/10/28 21:58:10, Vitaly Buka wrote:

[Vitaly Buka (NO REVIEWS), 2013/10/28 22:12:52]

Done.

 PRINTING_EXPORT extern const char kSettingOpenPDFInPreview[];
-#endif  // defined(OS_MACOSX)
 
 #if defined (USE_CUPS)
 // Printer color models