printing/print_job_constants.h - Issue 47823002: De-duplicate job_settings parsing code.

Side by Side Diff: printing/print_job_constants.h

Issue 47823002: De-duplicate job_settings parsing code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Review Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« printing/print_dialog_gtk_interface.h ('K') | « printing/print_dialog_gtk_interface.h ('k') | printing/print_job_constants.cc » ('j') | printing/print_settings.h » ('J')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef PRINTING_PRINT_JOB_CONSTANTS_H_	5 #ifndef PRINTING_PRINT_JOB_CONSTANTS_H_

6 #define PRINTING_PRINT_JOB_CONSTANTS_H_	6 #define PRINTING_PRINT_JOB_CONSTANTS_H_

7	7

8 #include "build/build_config.h"	8 #include "build/build_config.h"

9 #include "printing/printing_export.h"	9 #include "printing/printing_export.h"

10	10

(...skipping 35 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
46 PRINTING_EXPORT extern const char kSettingPrintableAreaY[];	46 PRINTING_EXPORT extern const char kSettingPrintableAreaY[];

47 PRINTING_EXPORT extern const char kSettingPrintableAreaWidth[];	47 PRINTING_EXPORT extern const char kSettingPrintableAreaWidth[];

48 PRINTING_EXPORT extern const char kSettingPrintableAreaHeight[];	48 PRINTING_EXPORT extern const char kSettingPrintableAreaHeight[];

49 PRINTING_EXPORT extern const char kSettingPrinterName[];	49 PRINTING_EXPORT extern const char kSettingPrinterName[];

50 PRINTING_EXPORT extern const char kSettingPrintToPDF[];	50 PRINTING_EXPORT extern const char kSettingPrintToPDF[];

51 PRINTING_EXPORT extern const char kSettingShouldPrintBackgrounds[];	51 PRINTING_EXPORT extern const char kSettingShouldPrintBackgrounds[];

52 PRINTING_EXPORT extern const char kSettingShouldPrintSelectionOnly[];	52 PRINTING_EXPORT extern const char kSettingShouldPrintSelectionOnly[];

53	53

54 PRINTING_EXPORT extern const int FIRST_PAGE_INDEX;	54 PRINTING_EXPORT extern const int FIRST_PAGE_INDEX;

55 PRINTING_EXPORT extern const int COMPLETE_PREVIEW_DOCUMENT_INDEX;	55 PRINTING_EXPORT extern const int COMPLETE_PREVIEW_DOCUMENT_INDEX;

56

57 #if defined(OS_MACOSX)
Noam Samuel 2013/10/28 21:52:39 Is "Preview" a reference to print preview, or the Is "Preview" a reference to print preview, or the application Preview in Mac OSX? Vitaly Buka (NO REVIEWS) 2013/10/28 21:58:10 Yes. It's MacOSX preview. I'd like to have code le Yes. It's MacOSX preview. I'd like to have code less platform dependent so I remove this ifdef. On 2013/10/28 21:52:39, Noam Samuel wrote: Show quoted text > Is "Preview" a reference to print preview, or the application Preview in Mac > OSX? Noam Samuel 2013/10/28 22:03:01 Maybe it's worth a comment explaining it? I could Maybe it's worth a comment explaining it? I could guess what it meant based on the ifdefs, but without them it's not 100% clear. On 2013/10/28 21:58:10, Vitaly Buka wrote: Show quoted text > Yes. It's MacOSX preview. > I'd like to have code less platform dependent so I remove this ifdef. > > On 2013/10/28 21:52:39, Noam Samuel wrote: > > Is "Preview" a reference to print preview, or the application Preview in Mac > > OSX? > Vitaly Buka (NO REVIEWS) 2013/10/28 22:12:52 Done. Show quoted text On 2013/10/28 22:03:01, Noam Samuel wrote: > Maybe it's worth a comment explaining it? I could guess what it meant based on > the ifdefs, but without them it's not 100% clear. > > On 2013/10/28 21:58:10, Vitaly Buka wrote: > > Yes. It's MacOSX preview. > > I'd like to have code less platform dependent so I remove this ifdef. > > > > On 2013/10/28 21:52:39, Noam Samuel wrote: > > > Is "Preview" a reference to print preview, or the application Preview in Mac > > > OSX? > > > Done.
58 PRINTING_EXPORT extern const char kSettingOpenPDFInPreview[];	56 PRINTING_EXPORT extern const char kSettingOpenPDFInPreview[];

59 #endif // defined(OS_MACOSX)

60	57

61 #if defined (USE_CUPS)	58 #if defined (USE_CUPS)

62 // Printer color models	59 // Printer color models

63 PRINTING_EXPORT extern const char kBlack[];	60 PRINTING_EXPORT extern const char kBlack[];

64 PRINTING_EXPORT extern const char kCMYK[];	61 PRINTING_EXPORT extern const char kCMYK[];

65 PRINTING_EXPORT extern const char kKCMY[];	62 PRINTING_EXPORT extern const char kKCMY[];

66 PRINTING_EXPORT extern const char kCMY_K[];	63 PRINTING_EXPORT extern const char kCMY_K[];

67 PRINTING_EXPORT extern const char kCMY[];	64 PRINTING_EXPORT extern const char kCMY[];

68 PRINTING_EXPORT extern const char kColor[];	65 PRINTING_EXPORT extern const char kColor[];

69 PRINTING_EXPORT extern const char kGray[];	66 PRINTING_EXPORT extern const char kGray[];

(...skipping 57 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
127 enum MarginType {	124 enum MarginType {

128 DEFAULT_MARGINS, // Default varies depending on headers being enabled or not	125 DEFAULT_MARGINS, // Default varies depending on headers being enabled or not

129 NO_MARGINS,	126 NO_MARGINS,

130 PRINTABLE_AREA_MARGINS,	127 PRINTABLE_AREA_MARGINS,

131 CUSTOM_MARGINS,	128 CUSTOM_MARGINS,

132 };	129 };

133	130

134 } // namespace printing	131 } // namespace printing

135	132

136 #endif // PRINTING_PRINT_JOB_CONSTANTS_H_	133 #endif // PRINTING_PRINT_JOB_CONSTANTS_H_

OLD	NEW