De-duplicate job_settings parsing code.

printing/print_dialog_gtk_interface.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef PRINTING_PRINT_DIALOG_GTK_INTERFACE_H_
 #define PRINTING_PRINT_DIALOG_GTK_INTERFACE_H_
 
 #include "base/strings/string16.h"
 #include "printing/printing_context_gtk.h"
 #include "ui/gfx/native_widget_types.h"
 
 namespace printing {
 
 class Metafile;
 class PrintSettings;
 
 // An interface for GTK printing dialogs. Classes that live outside of
 // printing/ can implement this interface and get threading requirements
 // correct without exposing those requirements to printing/.
 class PrintDialogGtkInterface {
  public:
   // Tell the dialog to use the default print setting.
   virtual void UseDefaultSettings() = 0;
 
-  // Update the dialog to use |job_settings| and |ranges|, where |job_settings|
-  // is a dictionary of settings with possible keys from
-  // printing/print_job_constants.h. Only used when printing without the system
-  // print dialog. E.g. for Print Preview. Returns false on error.
-  virtual bool UpdateSettings(const base::DictionaryValue& job_settings,
-                              const PageRanges& ranges,
+  // Updates the dialog to use |settings|. Only used when printing without the
+  // system print dialog. E.g. for Print Preview. Returns false on error.
+  // |pdf_only| is true if implementation needs to generate PDF without actual

[Lei Zhang, 2013/10/28 23:40:23]

|pdf_only| -> |target_is_pdf|

[Vitaly Buka (NO REVIEWS), 2013/10/29 00:31:21]

Done.

+  // printing. In this case implementation may avoid setup of native print
+  // system. Ex. "save to pdf" or Cloud Print.
+  virtual bool UpdateSettings(bool target_is_pdf,
                               PrintSettings* settings) = 0;
 
   // Shows the dialog and handles the response with |callback|. Only used when
   // printing with the native print dialog.
   virtual void ShowDialog(
       gfx::NativeView parent_view,
       bool has_selection,
       const PrintingContextGtk::PrintSettingsCallback& callback) = 0;
 
   // Prints the document named |document_name| contained in |metafile|.
   // Called from the print worker thread. Once called, the
   // PrintDialogGtkInterface instance should not be reused.
   virtual void PrintDocument(const Metafile* metafile,
                              const base::string16& document_name) = 0;
 
   // Same as AddRef/Release, but with different names since
   // PrintDialogGtkInterface does not inherit from RefCounted.
   virtual void AddRefToDialog() = 0;
   virtual void ReleaseDialog() = 0;
 
  protected:
   virtual ~PrintDialogGtkInterface() {}
 };
 
 }  // namespace printing
 
 #endif  // PRINTING_PRINT_DIALOG_GTK_INTERFACE_H_