Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1812)

Unified Diff: chrome/browser/printing/print_job_worker.h

Issue 478183005: Added PrintingContext::Delegate to get parent view handle and application locale. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Wed Aug 20 16:46:22 PDT 2014 Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/printing/print_job_worker.h
diff --git a/chrome/browser/printing/print_job_worker.h b/chrome/browser/printing/print_job_worker.h
index 2f6d2371c99181bf7531be021235c7bd2cbf60b1..cc10ee5b01edf9cfc906ec5f749e21346a94409c 100644
--- a/chrome/browser/printing/print_job_worker.h
+++ b/chrome/browser/printing/print_job_worker.h
@@ -24,7 +24,6 @@ class PrintJob;
class PrintJobWorkerOwner;
class PrintedDocument;
class PrintedPage;
-class PrintingUIWebContentsObserver;
// Worker thread code. It manages the PrintingContext, which can be blocking
// and/or run a message loop. This is the object that generates most
@@ -33,7 +32,9 @@ class PrintingUIWebContentsObserver;
// PrintJob always outlives its worker instance.
class PrintJobWorker {
public:
- explicit PrintJobWorker(PrintJobWorkerOwner* owner);
+ PrintJobWorker(int render_process_id,
+ int render_view_id,
+ PrintJobWorkerOwner* owner);
virtual ~PrintJobWorker();
void SetNewOwner(PrintJobWorkerOwner* new_owner);
@@ -46,14 +47,12 @@ class PrintJobWorker {
// Print... dialog box will be shown to ask the user his preference.
void GetSettings(
bool ask_user_for_settings,
- scoped_ptr<PrintingUIWebContentsObserver> web_contents_observer,
int document_page_count,
bool has_selection,
MarginType margin_type);
// Set the new print settings.
- void SetSettings(
- scoped_ptr<base::DictionaryValue> new_settings);
+ void SetSettings(scoped_ptr<base::DictionaryValue> new_settings);
// Starts the printing loop. Every pages are printed as soon as the data is
// available. Makes sure the new_document is the right one.
@@ -112,7 +111,6 @@ class PrintJobWorker {
// Required on Mac and Linux. Windows can display UI from non-main threads,
// but sticks with this for consistency.
void GetSettingsWithUI(
- scoped_ptr<PrintingUIWebContentsObserver> web_contents_observer,
int document_page_count,
bool has_selection);
@@ -132,6 +130,9 @@ class PrintJobWorker {
// systems.
void UseDefaultSettings();
+ // Printing context delegate.
+ scoped_ptr<PrintingContext::Delegate> printing_context_delegate_;
+
// Information about the printer setting.
scoped_ptr<PrintingContext> printing_context_;

Powered by Google App Engine
This is Rietveld 408576698