test/test262: update testcfg.py for new test262

test/test262/testcfg.py

 # Copyright 2012 the V8 project authors. All rights reserved.
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 #       notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 #       copyright notice, this list of conditions and the following
 #       disclaimer in the documentation and/or other materials provided
@@ skipping 18 matching lines @@
 import hashlib
 import os
 import shutil
 import sys
 import tarfile
 
 from testrunner.local import testsuite
 from testrunner.local import utils
 from testrunner.objects import testcase
 
+TEST_262_ARCHIVE_REVISION = "595a36b"  # This is the 2014-Aug-10 revision.
+TEST_262_ARCHIVE_MD5 = "89dfc8458f474cdb7e8e178f3215dd06"
+TEST_262_URL = "https://github.com/tc39/test262/tarball/%s"
+TEST_262_HARNESS = ["sta.js"]
 
-TEST_262_ARCHIVE_REVISION = "fbba29f"  # This is the r365 revision.
-TEST_262_ARCHIVE_MD5 = "e1ff0db438cc12de8fb6da80621b4ef6"
-TEST_262_URL = "https://github.com/tc39/test262/tarball/%s"
-TEST_262_HARNESS = ["sta.js", "testBuiltInObject.js", "testIntl.js"]
+TEST_262_ROOT = ["data", "test"]
+TEST_262_SUITE_ROOT = TEST_262_ROOT + ["suite"]
+TEST_262_HARNESS_ROOT = TEST_262_ROOT + ["harness"]
+TEST_262_PYTHON_ROOT = ["data", "tools", "packaging"]

[Jakob Kummerow, 2014/08/18 17:18:39]

Since this is now only used in the line right below, I'd inline it there. But
come to think of it, there's more cleanup we should do:
- os.path.abspath("test/test262") is essentially what's passed in to GetSuite as
"root". We should re-use that rather than hard-code and duplicate it. Which
means the import trickery must go into GetSuite (which shouldn't hurt, AFAICT).
- It seems a bit arbitrary which variables are pulled out and which aren't.
- Having four paths named <x>_ROOT is a bit confusing.

Putting it all together gives us something like:

TEST_262_TESTS_PATH = ["data", "test", "suite"]
TEST_262_HARNESS_PATH = ["data", "test", "harness"]
TEST_262_TOOLS_PATH = ["data", "tools", "packaging"]

...

def GetSuite(name, root):
  ...
  sys.path.append(os.path.join(root, *TEST_262_TOOLS_PATH))
  # or the 'imp' version you're coming up with
  ...
  return Test262TestSuite(name, root)

[smikes, 2014/08/18 19:38:01]

I think it can't go into GetSuite because GetSuite has to succeed in
order for DownloadData to run, and we would like to be able to
--download-data and run in the same step.  I pulled it into its own function
LoadParseTestRecord

+TEST_262_PYTHON_PATH = os.path.join('test', 'test262', *TEST_262_PYTHON_ROOT)
 
+original_sys_path = sys.path
+sys.path.append(os.path.abspath(TEST_262_PYTHON_PATH))
+try:
+  from parseTestRecord import parseTestRecord as ParseTestRecord
+except ImportError:
+  print "Need to --download-data for test262"
+sys.path = original_sys_path
 
 class Test262TestSuite(testsuite.TestSuite):
 
   def __init__(self, name, root):
     super(Test262TestSuite, self).__init__(name, root)
-    self.testroot = os.path.join(root, "data", "test", "suite")
-    self.harness = [os.path.join(self.root, "data", "test", "harness", f)
+    self.testroot = os.path.join(self.root, *TEST_262_SUITE_ROOT)
+    self.harnesspath = os.path.join(self.root, *TEST_262_HARNESS_ROOT)
+    self.harness = [os.path.join(self.harnesspath, f)
                     for f in TEST_262_HARNESS]
     self.harness += [os.path.join(self.root, "harness-adapt.js")]
 
   def CommonTestName(self, testcase):
     return testcase.path.split(os.path.sep)[-1]
 
   def ListTests(self, context):
     tests = []
     for dirname, dirs, files in os.walk(self.testroot):
       for dotted in [x for x in dirs if x.startswith(".")]:
         dirs.remove(dotted)
       if context.noi18n and "intl402" in dirs:
         dirs.remove("intl402")
       dirs.sort()
       files.sort()
       for filename in files:
         if filename.endswith(".js"):
           testname = os.path.join(dirname[len(self.testroot) + 1:],
                                   filename[:-3])
           case = testcase.TestCase(self, testname)
           tests.append(case)
     return tests
 
   def GetFlagsForTestCase(self, testcase, context):
     return (testcase.flags + context.mode_flags + self.harness +
+            self.GetIncludesForTest(testcase) +
             [os.path.join(self.testroot, testcase.path + ".js")])
 
+  def GetTestRecord(self, testcase):
+    if hasattr(testcase, "test_record"):

[Jakob Kummerow, 2014/08/18 17:18:39]

nit: one return statement is more readable, and in this case easy to achieve:

    if not hasattr(testcase, "test_record"):
      testcase.test_record = ...
    return testcase.test_record

[smikes, 2014/08/18 19:38:01]

Done.

+      return testcase.test_record
+    testcase.test_record = ParseTestRecord(self.GetSourceForTest(testcase),
+                                           testcase.path)
+    return testcase.test_record
+
+  def GetIncludesForTest(self, testcase):
+    test_record = self.GetTestRecord(testcase)
+    if "includes" in test_record:
+      return [os.path.join(self.harnesspath, f)
+              for f in test_record['includes']]
+    return []
+
   def GetSourceForTest(self, testcase):
     filename = os.path.join(self.testroot, testcase.path + ".js")
     with open(filename) as f:
-      return f.read()
+      testcase.source = f.read()
+    return testcase.source
 
   def IsNegativeTest(self, testcase):
-    return "@negative" in self.GetSourceForTest(testcase)
+    test_record = self.GetTestRecord(testcase)
+    if "negative" in test_record:
+      return test_record['negative']

[Jakob Kummerow, 2014/08/18 17:18:39]

one more nit: the rest of this file uses double quotes around strings, let's be
consistent.

[smikes, 2014/08/18 19:38:01]

Done.

+    return False
 
   def IsFailureOutput(self, output, testpath):
     if output.exit_code != 0:
       return True
     return "FAILED!" in output.stdout
 
   def DownloadData(self):
     revision = TEST_262_ARCHIVE_REVISION
     archive_url = TEST_262_URL % revision
     archive_name = os.path.join(self.root, "tc39-test262-%s.tar.gz" % revision)
@@ skipping 20 matching lines @@
         # Magic incantation to allow longer path names on Windows.
         archive.extractall(u"\\\\?\\%s" % self.root)
       else:
         archive.extractall(self.root)
       os.rename(os.path.join(self.root, "tc39-test262-%s" % revision),
                 directory_name)
 
 
 def GetSuite(name, root):
   return Test262TestSuite(name, root)