Change the wire format of the ack frame to include a compressed version

net/quic/quic_network_transaction_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/stl_util.h"
@@ skipping 125 matching lines @@
   }
 
   scoped_ptr<QuicEncryptedPacket> ConstructConnectionClosePacket(
       QuicPacketSequenceNumber num) {
     return maker_.MakeConnectionClosePacket(num);
   }
 
   scoped_ptr<QuicEncryptedPacket> ConstructAckPacket(
       QuicPacketSequenceNumber largest_received,
       QuicPacketSequenceNumber least_unacked) {
-    return maker_.MakeAckPacket(2, largest_received, least_unacked, true);
+    return maker_.MakeAckPacket(2, largest_received, least_unacked, true,
+                                clock_->Now());

[ramant (doing other things), 2014/08/23 23:55:28]

Hi Ryan,
  In QuicFramer::AppendTimestampToAckFrame, the time sent is relative to
framer's creation time (which is based on MockClock).

  In Client code, framer was created with 20000 ms as the creation time and we
send zero for received_packet_times in actual data.

  In the quic_test_packet_maker.cc, framer was created with zero time and thus
we were passing ' N' in the expected data instead of zero (and that's why the
chromium's specific tests were failing).

  Not 100% sure if "timestamp" is the right name. For Version_23 also, we say
"timestamp" (a better description could be better).

  The following are the files that are chromium specific:

net/quic/quic_http_stream_test.cc
net/quic/quic_network_transaction_unittest.cc
net/quic/test_tools/quic_test_packet_maker.cc
net/quic/test_tools/quic_test_packet_maker.h

[Ryan Hamilton, 2014/08/25 22:07:51]

Alternatively, consider passing a clock in to the
QuicTestPacketMakerConstructor.

[ramant (doing other things), 2014/08/25 23:39:35]

Thanks for the above suggestion.

Done.

   }
 
   SpdyHeaderBlock GetRequestHeaders(const std::string& method,
                                     const std::string& scheme,
                                     const std::string& path) {
     return maker_.GetRequestHeaders(method, scheme, path);
   }
 
   SpdyHeaderBlock GetResponseHeaders(const std::string& status) {
     return maker_.GetResponseHeaders(status);
@@ skipping 875 matching lines @@
                          NULL,
                          net_log_.bound());
 
   CreateSessionWithNextProtos();
   AddQuicAlternateProtocolMapping(MockCryptoClientStream::ZERO_RTT);
   SendRequestAndExpectHttpResponse("hello world");
 }
 
 }  // namespace test
 }  // namespace net