mesa: Don't build mapi.h / mapi.c

mesa: Don't build mapi.h / mapi.c

We don't need them, and they unconditionally mark their functions as
__declspec(dllimport) in the header in a static library build, which
causes warnings on the clang/win bot.

BUG=82385
R=kbr@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290207

[Ken Russell (switch to Gerrit), 2014-08-17 20:16:53]

How'd you determine that these files aren't needed?

[Nico, 2014-08-17 21:06:26]

The functions in there only seem to be called from glandium (which we don't
build), and things seem to compile, link, and run without them.
On Aug 17, 2014 1:16 PM, <kbr@chromium.org> wrote:

> How'd you determine that these files aren't needed?
>
>
> https://codereview.chromium.org/478153002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Nico, 2014-08-18 03:47:25]

On 2014/08/17 21:06:26, Nico (very away) wrote:
> The functions in there only seem to be called from glandium (which we don't
> build), and things seem to compile, link, and run without them.

(If the question was "how did I find this": I looked at build warnings on the
clang/win fyi bot:
http://build.chromium.org/p/chromium.fyi/builders/Cr%20Win%20Clang/builds/106...
– search for "warning(clang". The import define in mapi.h looked funny to me
– it always uses __declspec(dllimport) when not doing a components build, so I
wondered if this could even work, and then noticed that these functions very
likely just aren't used.)

[Ken Russell (switch to Gerrit), 2014-08-18 04:05:28]

On 2014/08/18 03:47:25, Nico (very away) wrote:
> On 2014/08/17 21:06:26, Nico (very away) wrote:
> > The functions in there only seem to be called from glandium (which we don't
> > build), and things seem to compile, link, and run without them.
> 
> (If the question was "how did I find this": I looked at build warnings on the
> clang/win fyi bot:
>
http://build.chromium.org/p/chromium.fyi/builders/Cr%20Win%20Clang/builds/106...
> – search for "warning(clang". The import define in mapi.h looked funny to me
> – it always uses __declspec(dllimport) when not doing a components build,
so I
> wondered if this could even work, and then noticed that these functions very
> likely just aren't used.)

OK. Thanks for the info. I ask mainly because during the last Mesa upgrade it
was difficult to figure out which portions of the library were needed, so an
attempt was made to include all the sources used by the normal build process.

Could you update README.chromium in this directory to point out the exclusion of
these two files?

LGTM

[Nico, 2014-08-18 04:19:35]

Committed patchset #2 manually as 290207 (presubmit successful).