Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Side by Side Diff: src/ia32/stub-cache-ia32.cc

Issue 478043006: Rewrite StoreIC handling using the LookupIterator. Continued from patch 494153002 (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm64/stub-cache-arm64.cc ('k') | src/ic.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_IA32 7 #if V8_TARGET_ARCH_IA32
8 8
9 #include "src/codegen.h" 9 #include "src/codegen.h"
10 #include "src/ic-inl.h" 10 #include "src/ic-inl.h"
(...skipping 550 matching lines...) Expand 10 before | Expand all | Expand 10 after
561 smi_check); 561 smi_check);
562 } 562 }
563 } 563 }
564 564
565 // Return the value (register eax). 565 // Return the value (register eax).
566 DCHECK(value_reg.is(eax)); 566 DCHECK(value_reg.is(eax));
567 __ ret(0); 567 __ ret(0);
568 } 568 }
569 569
570 570
571 void NamedStoreHandlerCompiler::GenerateStoreField(LookupResult* lookup, 571 void NamedStoreHandlerCompiler::GenerateStoreField(LookupIterator* lookup,
572 Register value_reg, 572 Register value_reg,
573 Label* miss_label) { 573 Label* miss_label) {
574 DCHECK(lookup->representation().IsHeapObject()); 574 DCHECK(lookup->representation().IsHeapObject());
575 __ JumpIfSmi(value_reg, miss_label); 575 __ JumpIfSmi(value_reg, miss_label);
576 HeapType::Iterator<Map> it = lookup->GetFieldType()->Classes(); 576 HeapType::Iterator<Map> it = lookup->GetFieldType()->Classes();
577 Label do_store; 577 Label do_store;
578 while (true) { 578 while (true) {
579 __ CompareMap(value_reg, it.Current()); 579 __ CompareMap(value_reg, it.Current());
580 it.Advance(); 580 it.Advance();
581 if (it.Done()) { 581 if (it.Done()) {
(...skipping 596 matching lines...) Expand 10 before | Expand all | Expand 10 after
1178 // ----------------------------------- 1178 // -----------------------------------
1179 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss); 1179 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss);
1180 } 1180 }
1181 1181
1182 1182
1183 #undef __ 1183 #undef __
1184 1184
1185 } } // namespace v8::internal 1185 } } // namespace v8::internal
1186 1186
1187 #endif // V8_TARGET_ARCH_IA32 1187 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/arm64/stub-cache-arm64.cc ('k') | src/ic.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698