Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Side by Side Diff: src/arm/stub-cache-arm.cc

Issue 478043006: Rewrite StoreIC handling using the LookupIterator. Continued from patch 494153002 (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/arm64/stub-cache-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM 7 #if V8_TARGET_ARCH_ARM
8 8
9 #include "src/codegen.h" 9 #include "src/codegen.h"
10 #include "src/ic-inl.h" 10 #include "src/ic-inl.h"
(...skipping 563 matching lines...) Expand 10 before | Expand all | Expand 10 after
574 } 574 }
575 } 575 }
576 576
577 // Return the value (register r0). 577 // Return the value (register r0).
578 DCHECK(value_reg.is(r0)); 578 DCHECK(value_reg.is(r0));
579 __ bind(&exit); 579 __ bind(&exit);
580 __ Ret(); 580 __ Ret();
581 } 581 }
582 582
583 583
584 void NamedStoreHandlerCompiler::GenerateStoreField(LookupResult* lookup, 584 void NamedStoreHandlerCompiler::GenerateStoreField(LookupIterator* lookup,
585 Register value_reg, 585 Register value_reg,
586 Label* miss_label) { 586 Label* miss_label) {
587 DCHECK(lookup->representation().IsHeapObject()); 587 DCHECK(lookup->representation().IsHeapObject());
588 __ JumpIfSmi(value_reg, miss_label); 588 __ JumpIfSmi(value_reg, miss_label);
589 HeapType::Iterator<Map> it = lookup->GetFieldType()->Classes(); 589 HeapType::Iterator<Map> it = lookup->GetFieldType()->Classes();
590 __ ldr(scratch1(), FieldMemOperand(value_reg, HeapObject::kMapOffset)); 590 __ ldr(scratch1(), FieldMemOperand(value_reg, HeapObject::kMapOffset));
591 Label do_store; 591 Label do_store;
592 while (true) { 592 while (true) {
593 __ CompareMap(scratch1(), it.Current(), &do_store); 593 __ CompareMap(scratch1(), it.Current(), &do_store);
594 it.Advance(); 594 it.Advance();
(...skipping 568 matching lines...) Expand 10 before | Expand all | Expand 10 after
1163 1163
1164 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss); 1164 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss);
1165 } 1165 }
1166 1166
1167 1167
1168 #undef __ 1168 #undef __
1169 1169
1170 } } // namespace v8::internal 1170 } } // namespace v8::internal
1171 1171
1172 #endif // V8_TARGET_ARCH_ARM 1172 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/arm64/stub-cache-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698