Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 478043005: Add the mp2t mimetype to the list of supported mime types. (Closed)

Created:
6 years, 4 months ago by damienv1
Modified:
6 years, 3 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, cbentzel+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Add the mp2t mimetype to the list of supported mime types. The mp2t mimetype is now supported when the mpeg2 TS stream parser is enabled. This change is required since isTypeSupported involves that CanPlayType for the same mime type is at least maybe. This condition is now enforced at Blink level. BUG=None Committed: https://crrev.com/a6c976378bd6485a520f0806e82126b25047d1c9 Cr-Commit-Position: refs/heads/master@{#292073}

Patch Set 1 #

Total comments: 9

Patch Set 2 : Address CR comments from patch set #1. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -15 lines) Patch
M build/common.gypi View 1 1 chunk +5 lines, -0 lines 0 comments Download
M media/BUILD.gn View 1 1 chunk +0 lines, -3 lines 0 comments Download
M media/media.gyp View 2 chunks +0 lines, -12 lines 0 comments Download
M net/base/mime_util.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M net/base/mime_util_unittest.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
damienv1
Please take a look. Thanks !
6 years, 4 months ago (2014-08-21 16:53:17 UTC) #1
acolwell GONE FROM CHROMIUM
lgtm https://codereview.chromium.org/478043005/diff/1/net/base/mime_util.cc File net/base/mime_util.cc (right): https://codereview.chromium.org/478043005/diff/1/net/base/mime_util.cc#newcode385 net/base/mime_util.cc:385: "video/mp2t", nit: Should we have audio/mp2t as well? ...
6 years, 4 months ago (2014-08-22 19:12:30 UTC) #2
wolenetz
https://codereview.chromium.org/478043005/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/478043005/diff/1/build/common.gypi#newcode2593 build/common.gypi:2593: ['enable_mpeg2ts_stream_parser==1', { In old media.gyp, the 'media' target's inspection ...
6 years, 4 months ago (2014-08-22 19:53:17 UTC) #3
szym
net: lgtm https://codereview.chromium.org/478043005/diff/1/net/base/mime_util.cc File net/base/mime_util.cc (right): https://codereview.chromium.org/478043005/diff/1/net/base/mime_util.cc#newcode384 net/base/mime_util.cc:384: // Mpeg2 TS. nit: MPEG-2 TS.
6 years, 4 months ago (2014-08-24 08:40:34 UTC) #4
damienv1
https://codereview.chromium.org/478043005/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/478043005/diff/1/build/common.gypi#newcode2593 build/common.gypi:2593: ['enable_mpeg2ts_stream_parser==1', { On 2014/08/22 19:53:17, wolenetz wrote: > In ...
6 years, 3 months ago (2014-08-26 14:43:20 UTC) #5
wolenetz
lgtm % GN: ILTM like the GN build with PS2 may not include MPEG2-TS (or ...
6 years, 3 months ago (2014-08-26 20:17:12 UTC) #6
damienv1
Dale, I was looking at top level GN files in build/ and I don't see ...
6 years, 3 months ago (2014-08-26 20:22:06 UTC) #7
DaleCurtis
lgtm https://codereview.chromium.org/478043005/diff/1/media/media.gyp File media/media.gyp (left): https://codereview.chromium.org/478043005/diff/1/media/media.gyp#oldcode971 media/media.gyp:971: 'conditions': [ On 2014/08/26 14:43:20, damienv1 wrote: > ...
6 years, 3 months ago (2014-08-26 20:43:19 UTC) #8
damienv1
Thanks Dale for the feedback. Since top level GN fix won't be part of this ...
6 years, 3 months ago (2014-08-26 21:50:40 UTC) #9
damienv1
The CQ bit was checked by damienv@chromium.org
6 years, 3 months ago (2014-08-27 00:53:40 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/damienv@chromium.org/478043005/20001
6 years, 3 months ago (2014-08-27 00:54:20 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (20001) as e8faa48e427b73cdf43d7899bcd70f88ab50d175
6 years, 3 months ago (2014-08-27 01:48:06 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:48:56 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a6c976378bd6485a520f0806e82126b25047d1c9
Cr-Commit-Position: refs/heads/master@{#292073}

Powered by Google App Engine
This is Rietveld 408576698