Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 478033004: Fix a couple of scroll-related issues: (Closed)

Created:
6 years, 4 months ago by Jamie
Modified:
6 years, 3 months ago
Reviewers:
garykac
CC:
chromium-reviews, chromoting-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Fix a couple of scroll-related issues: * It was possible to click behind the dialog screen by scrolling it out of the way. * When connecting to a host, scroll-bars appeared, regardless of the window size. Committed: https://crrev.com/add1a57f163fb9362c550c964a3c93646a0150b2 Cr-Commit-Position: refs/heads/master@{#291714}

Patch Set 1 #

Total comments: 5

Patch Set 2 : Fixed position and size for apps v1. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -6 lines) Patch
M remoting/webapp/client_session.js View 2 chunks +2 lines, -0 lines 0 comments Download
M remoting/webapp/html/template_main.html View 2 chunks +4 lines, -4 lines 0 comments Download
M remoting/webapp/main.css View 1 3 chunks +16 lines, -0 lines 0 comments Download
M remoting/webapp/window_frame.js View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Jamie
ptal https://codereview.chromium.org/478033004/diff/1/remoting/webapp/client_session.js File remoting/webapp/client_session.js (right): https://codereview.chromium.org/478033004/diff/1/remoting/webapp/client_session.js#newcode588 remoting/webapp/client_session.js:588: document.body.classList.remove('connected'); This class was previously only used to ...
6 years, 4 months ago (2014-08-23 00:12:00 UTC) #1
garykac1
https://codereview.chromium.org/478033004/diff/1/remoting/webapp/main.css File remoting/webapp/main.css (right): https://codereview.chromium.org/478033004/diff/1/remoting/webapp/main.css#newcode630 remoting/webapp/main.css:630: height: calc(100% - 2px); On 2014/08/23 00:12:00, Jamie wrote: ...
6 years, 4 months ago (2014-08-23 00:21:40 UTC) #2
Jamie
https://codereview.chromium.org/478033004/diff/1/remoting/webapp/main.css File remoting/webapp/main.css (right): https://codereview.chromium.org/478033004/diff/1/remoting/webapp/main.css#newcode630 remoting/webapp/main.css:630: height: calc(100% - 2px); On 2014/08/23 00:21:40, garykac1 wrote: ...
6 years, 4 months ago (2014-08-23 00:32:57 UTC) #3
garykac
lgtm
6 years, 4 months ago (2014-08-23 00:49:33 UTC) #4
Jamie
The CQ bit was checked by jamiewalch@chromium.org
6 years, 4 months ago (2014-08-25 17:09:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamiewalch@chromium.org/478033004/20001
6 years, 4 months ago (2014-08-25 17:09:43 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (20001) as ccaaaa4ccd41138748d5396019acca251d758485
6 years, 4 months ago (2014-08-25 18:07:53 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:35:41 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/add1a57f163fb9362c550c964a3c93646a0150b2
Cr-Commit-Position: refs/heads/master@{#291714}

Powered by Google App Engine
This is Rietveld 408576698