content/browser/renderer_host/render_widget_host_view_aura_unittest.cc - Issue 478023002: OverscrollController consumes scroll updates only during gesture-nav.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura_unittest.cc

Issue 478023002: OverscrollController consumes scroll updates only during gesture-nav. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/overscroll_controller_delegate.h ('k') | content/browser/web_contents/aura/gesture_nav_simple.h » ('j') | content/browser/web_contents/web_contents_view_aura_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_aura_unittest.cc

diff --git a/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc b/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc

index 49f017879e0281cd0663b6f2a41321aca12f4ed6..dcf0e137c4e846c0bc67e6bdd07ec8e673b9c845 100644

--- a/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc

+++ b/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc

@@ -123,9 +123,10 @@ class TestOverscrollDelegate : public OverscrollControllerDelegate {

return view_->IsShowing() ? view_->GetViewBounds() : gfx::Rect();

}

- virtual void OnOverscrollUpdate(float delta_x, float delta_y) OVERRIDE {

+ virtual bool OnOverscrollUpdate(float delta_x, float delta_y) OVERRIDE {

delta_x_ = delta_x;

delta_y_ = delta_y;

+ return true;

}

virtual void OnOverscrollComplete(OverscrollMode overscroll_mode) OVERRIDE {