PerformanceTests/Animation/api-balls-keyframe-animations.html - Issue 478003002: Fill in descriptions on relevant blink_perf tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: PerformanceTests/Animation/api-balls-keyframe-animations.html

Issue 478003002: Fill in descriptions on relevant blink_perf tests (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Clarified APIs and improved some language on animation benchmarks Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: PerformanceTests/Animation/api-balls-keyframe-animations.html

diff --git a/PerformanceTests/Animation/api-balls-keyframe-animations.html b/PerformanceTests/Animation/api-balls-keyframe-animations.html

index f346116b552b1a58377a5b9522c99678d599626f..1f53c1fa37b9ff72efaa5de121252e772687789c 100644

--- a/PerformanceTests/Animation/api-balls-keyframe-animations.html

+++ b/PerformanceTests/Animation/api-balls-keyframe-animations.html

@@ -71,7 +71,11 @@ var particles = [];

var allParticleKeyframes = [];

window.onload = function () {

- PerfTestRunner.prepareToMeasureValuesAsync({done: onCompletedRun, unit: 'fps'});

+ PerfTestRunner.prepareToMeasureValuesAsync({

+ description: "Measure performance of Web Animations API animating 'left' and 'top' usingElement.animate()",

alancutter (OOO until 2018) 2014/10/20 00:09:34 Missing space before "using" and "Element".

+ done: onCompletedRun,

+ unit: 'fps'

+ });

// Create the particles

for (var i = 0; i < maxParticles; i++) {