net/disk_cache/entry_unittest.cc - Issue 477973002: Add Keys() function to ServiceWorkerCache.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/disk_cache/entry_unittest.cc

Issue 477973002: Add Keys() function to ServiceWorkerCache. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cache_patch

Patch Set: Address comments from PS11 and enable SimpleCache everywhere Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/disk_cache/entry_unittest.cc

diff --git a/net/disk_cache/entry_unittest.cc b/net/disk_cache/entry_unittest.cc

index 5fd6db01ecdd22a95964d398738660996af7f27e..ae1e524a39f39c3d472fd3596fd283c37c81451a 100644

--- a/net/disk_cache/entry_unittest.cc

+++ b/net/disk_cache/entry_unittest.cc

@@ -2449,7 +2449,7 @@ TEST_F(DiskCacheEntryTest, SimpleCacheInvalidData) {

}

-TEST_F(DiskCacheEntryTest, SimpleCacheReadWriteDestroyBuffer) {

+TEST_F(DiskCacheEntryTest, SimpleCacheReadOriteDestroyBuffer) {

michaeln 2014/08/29 20:08:26 typo?

jkarlin 2014/09/02 11:31:37 Done.

// Proving that the test works well with optimistic operations enabled is

// subtle, instead run only in APP_CACHE mode to disable optimistic

// operations. Stream 0 always uses optimistic operations, so the test is not