OOP PDF - Add OpenPDFParamsParser class

chrome/browser/resources/pdf/viewport.js

Index: chrome/browser/resources/pdf/viewport.js
diff --git a/chrome/browser/resources/pdf/viewport.js b/chrome/browser/resources/pdf/viewport.js
index 7a225da2043546ef105544d78f385bb0c865ea54..39dd81b2756c4552e4c7eedfd4c973ed0bb8118c 100644
--- a/chrome/browser/resources/pdf/viewport.js
+++ b/chrome/browser/resources/pdf/viewport.js
@@ -45,6 +45,7 @@ function Viewport(window,
   this.pageDimensions_ = [];
   this.scrollbarWidth_ = scrollbarWidth;
   this.fittingType_ = Viewport.FittingType.NONE;
+  this.initialViewport_ = {};
 
   window.addEventListener('scroll', this.updateViewport_.bind(this));
   window.addEventListener('resize', this.resize_.bind(this));
@@ -176,6 +177,14 @@ Viewport.prototype = {
   },
 
   /**
+   * Initial viewport settings to be used to open pdf. These are
+   * set by parsing open pdf parameters.
+   */
+  set initialViewportSettings(viewportSettings) {
+    this.initialViewport_ = viewportSettings;
+  },

[raymes, 2014/08/27 01:02:24]

I think we don't need this setter, we can just call the member
"this.initialViewport" and set it directly.

Also, I think it would be better to hook this up before landing this CL.

[Nikhil, 2014/08/27 10:16:09]

Done.

+
+  /**
    * @type {Object} the size of the viewport excluding scrollbars.
    */
   get size() {