OOP PDF - Add OpenPDFParamsParser class

chrome/browser/resources/pdf/viewport.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * Returns the area of the intersection of two rectangles.
  * @param {Object} rect1 the first rect
  * @param {Object} rect2 the second rect
  * @return {number} the area of the intersection of the rects
  */
@@ skipping 27 matching lines @@
   this.sizer_ = sizer;
   this.viewportChangedCallback_ = viewportChangedCallback;
   this.beforeZoomCallback_ = beforeZoomCallback;
   this.afterZoomCallback_ = afterZoomCallback;
   this.allowedToChangeZoom_ = false;
   this.zoom_ = 1;
   this.documentDimensions_ = null;
   this.pageDimensions_ = [];
   this.scrollbarWidth_ = scrollbarWidth;
   this.fittingType_ = Viewport.FittingType.NONE;
+  this.initialViewport_ = {};
 
   window.addEventListener('scroll', this.updateViewport_.bind(this));
   window.addEventListener('resize', this.resize_.bind(this));
 }
 
 /**
  * Enumeration of page fitting types.
  * @enum {string}
  */
 Viewport.FittingType = {
@@ skipping 111 matching lines @@
 
   /**
    * Scroll the viewport to the specified position.
    * @type {Object} position the position to scroll to.
    */
   set position(position) {
     this.window_.scrollTo(position.x, position.y);
   },
 
   /**
+   * Initial viewport settings to be used to open pdf. These are
+   * set by parsing open pdf parameters.
+   */
+  set initialViewportSettings(viewportSettings) {
+    this.initialViewport_ = viewportSettings;
+  },

[raymes, 2014/08/27 01:02:24]

I think we don't need this setter, we can just call the member
"this.initialViewport" and set it directly.

Also, I think it would be better to hook this up before landing this CL.

[Nikhil, 2014/08/27 10:16:09]

Done.

+
+  /**
    * @type {Object} the size of the viewport excluding scrollbars.
    */
   get size() {
     var needsScrollbars = this.documentNeedsScrollbars_(this.zoom_);
     var scrollbarWidth = needsScrollbars.vertical ? this.scrollbarWidth_ : 0;
     var scrollbarHeight = needsScrollbars.horizontal ? this.scrollbarWidth_ : 0;
     return {
       width: this.window_.innerWidth - scrollbarWidth,
       height: this.window_.innerHeight - scrollbarHeight
     };
@@ skipping 351 matching lines @@
     spaceOnLeft = Math.max(spaceOnLeft, 0);
 
     return {
       x: x * this.zoom_ + spaceOnLeft - this.window_.pageXOffset,
       y: insetDimensions.y * this.zoom_ - this.window_.pageYOffset,
       width: insetDimensions.width * this.zoom_,
       height: insetDimensions.height * this.zoom_
     };
   }
 };