Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 477883003: Support SVG in event.path. (Closed)

Created:
6 years, 4 months ago by hayato
Modified:
6 years, 4 months ago
Reviewers:
esprehn, dglazkov
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Support SVG in event.path. The SVG instance tree was recently removed which also removed most of the gnarly event handling in SVG. Now we can support SVG also in event.path. BUG=402721 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180364

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -9 lines) Patch
A LayoutTests/fast/dom/shadow/event-path-svg.html View 1 chunk +15 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/shadow/event-path-svg-expected.txt View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/events/Event.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/events/EventPath.cpp View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
hayato
PTAL.
6 years, 4 months ago (2014-08-15 10:03:04 UTC) #1
dglazkov
The CQ bit was checked by dglazkov@chromium.org
6 years, 4 months ago (2014-08-15 15:11:35 UTC) #2
dglazkov
OMG, add functionality by removing code. Love this stuff. LGTM.
6 years, 4 months ago (2014-08-15 15:11:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hayato@chromium.org/477883003/1
6 years, 4 months ago (2014-08-15 15:12:52 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 15:17:50 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (1) as 180364

Powered by Google App Engine
This is Rietveld 408576698