Fix a hang issue due to inconsistent page number in the test file

Fix a hang issue due to inconsistent page number in the test file

Pdfium reads the page number from the field of '/Count' but it can't
load the number assigned by this field due to the damaged data. Add a
check to ensure that the required page should be one of loaded pages.

BUG=406090
R=tsepez@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/aeacba4

[jun_fang, 2014-08-21 23:31:31]

Hi Tom, please review this change. Thanks!

[Tom Sepez, 2014-08-22 00:23:31]

LGTM with nits.

https://codereview.chromium.org/477873003/diff/1/samples/pdfium_test.cc
File samples/pdfium_test.cc (right):

https://codereview.chromium.org/477873003/diff/1/samples/pdfium_test.cc#newco...
samples/pdfium_test.cc:307: size_t renderedPages = 0;
nit:  we use the rendered_pages style for local variables.

https://codereview.chromium.org/477873003/diff/1/samples/pdfium_test.cc#newco...
samples/pdfium_test.cc:311: continue;
nit: Should we count the bad pages, too, and output it below?

[jun_fang, 2014-08-22 01:07:25]

Updated per your comments. Thanks!

https://codereview.chromium.org/477873003/diff/1/samples/pdfium_test.cc
File samples/pdfium_test.cc (right):

https://codereview.chromium.org/477873003/diff/1/samples/pdfium_test.cc#newco...
samples/pdfium_test.cc:307: size_t renderedPages = 0;
On 2014/08/22 00:23:31, Tom Sepez wrote:
> nit:  we use the rendered_pages style for local variables.

Got it.

https://codereview.chromium.org/477873003/diff/1/samples/pdfium_test.cc#newco...
samples/pdfium_test.cc:311: continue;
On 2014/08/22 00:23:31, Tom Sepez wrote:
> nit: Should we count the bad pages, too, and output it below?

Will add it.

[jun_fang, 2014-08-22 23:42:47]

On 2014/08/22 00:23:31, Tom Sepez wrote:
> LGTM with nits.
> 
> https://codereview.chromium.org/477873003/diff/1/samples/pdfium_test.cc
> File samples/pdfium_test.cc (right):
> 
>
https://codereview.chromium.org/477873003/diff/1/samples/pdfium_test.cc#newco...
> samples/pdfium_test.cc:307: size_t renderedPages = 0;
> nit:  we use the rendered_pages style for local variables.
> 
>
https://codereview.chromium.org/477873003/diff/1/samples/pdfium_test.cc#newco...
> samples/pdfium_test.cc:311: continue;
> nit: Should we count the bad pages, too, and output it below?

The following fix is OK for you?

[Tom Sepez, 2014-08-22 23:44:46]

Yes.  (LGTM with nits means I trust you to be able to fix the simple nits and
land without further review).

[jun_fang, 2014-08-23 00:01:03]

On 2014/08/22 23:44:46, Tom Sepez wrote:
> Yes.  (LGTM with nits means I trust you to be able to fix the simple nits and
> land without further review).

Thanks.

[jun_fang, 2014-08-23 00:04:46]

Committed patchset #2 manually as aeacba4 (presubmit successful).