Allow users to perform queries in the omnibox which begin with a search shortcut.

chrome/browser/ui/omnibox/omnibox_edit_model.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/omnibox/omnibox_edit_model.h"
 
 #include <algorithm>
 #include <string>
 
 #include "base/auto_reset.h"
@@ skipping 882 matching lines @@
   has_temporary_text_ = false;
 
   if (user_input_in_progress_ || !in_revert_)
     delegate_->OnInputStateChanged();
 }
 
 void OmniboxEditModel::ClearKeyword(const base::string16& visible_text) {
   autocomplete_controller()->Stop(false);
   omnibox_controller_->ClearPopupKeywordMode();
 
-  const base::string16 window_text(keyword_ + visible_text);
+  // Add a space after the keyword to allow the user to continue typing without
+  // re-enabling keyword mode (http://crbug.com/393371)

[Peter Kasting, 2014/08/22 00:41:13]

Nit: Don't refer to bugs in code comments.  Provide any necessary explanation
for the reader directly in the comment.

+  const base::string16 window_text(keyword_ + base::ASCIIToUTF16(" ") +

[Peter Kasting, 2014/08/22 00:41:12]

Nit: Break after initial '(' instead; consider using assignment form instead of
constructor form to do the initialization to make this wrapping less
strange-looking

+   visible_text);

[Peter Kasting, 2014/08/22 00:41:12]

Nit: Continuations of previous lines are indented 4, not 2

 
   // Only reset the result if the edit text has changed since the
   // keyword was accepted, or if the popup is closed.
   if (just_deleted_text_ || !visible_text.empty() ||
       !(popup_model() && popup_model()->IsOpen())) {
     view_->OnBeforePossibleChange();
-    view_->SetWindowTextAndCaretPos(window_text.c_str(), keyword_.length(),
+    view_->SetWindowTextAndCaretPos(window_text.c_str(), keyword_.length() + 1,
         false, false);
     keyword_.clear();
     is_keyword_hint_ = false;
     view_->OnAfterPossibleChange();
     just_deleted_text_ = true;  // OnAfterPossibleChange() fails to clear this
                                 // since the edit contents have actually grown
                                 // longer.
   } else {
     is_keyword_hint_ = true;
-    view_->SetWindowTextAndCaretPos(window_text.c_str(), keyword_.length(),
+    view_->SetWindowTextAndCaretPos(window_text.c_str(), keyword_.length() + 1,
         false, true);
   }
 
   view_->UpdatePlaceholderText();
 }
 
 void OmniboxEditModel::OnSetFocus(bool control_down) {
   last_omnibox_focus_ = base::TimeTicks::Now();
   user_input_since_focus_ = false;
 
@@ skipping 544 matching lines @@
   // Update state and notify view if the omnibox has focus and the caret
   // visibility changed.
   const bool was_caret_visible = is_caret_visible();
   focus_state_ = state;
   if (focus_state_ != OMNIBOX_FOCUS_NONE &&
       is_caret_visible() != was_caret_visible)
     view_->ApplyCaretVisibility();
 
   delegate_->OnFocusChanged(focus_state_, reason);
 }