Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 477813002: Revert of Let SyncBackupManager keep backup data in memory until shutdown. Only persist (Closed)

Created:
6 years, 4 months ago by miu
Modified:
6 years, 4 months ago
Reviewers:
haitaol1, Nicolas Zea
CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, zea+watch_chromium.org, maniscalco+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Revert of Let SyncBackupManager keep backup data in memory until shutdown. Only persist (patchset #3 of https://codereview.chromium.org/455023003/) Reason for revert: sync_unit_tests broke on Linux dbg bot. http://build.chromium.org/p/chromium.linux/buildstatus?builder=Linux%20Tests%20%28dbg%29%282%29&number=48388 ------------------------------------------------------------ [ RUN ] SyncManagerTestWithMockScheduler.ReConfiguration GMOCK WARNING: Uninteresting mock function call - returning directly. Function call: Start(0) NOTE: You can safely ignore the above warning unless this call should not happen. Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call. See http://code.google.com/p/googlemock/wiki/CookBook#Knowing_When_to_Expect for details. Stack trace: ../../sync/internal_api/sync_manager_impl_unittest.cc:838: Failure Value of: storage_used_ Actual: 2880154539 Expected: InternalComponentsFactory::STORAGE_ON_DISK Which is: 1 [ FAILED ] SyncManagerTestWithMockScheduler.ReConfiguration (34 ms) [828/829] SyncManagerTestWithMockScheduler.ReConfiguration (34 ms) [0814/160010:ERROR:kill_posix.cc(191)] Unable to terminate process group 6975: No such process [ RUN ] SyncManagerTestWithMockScheduler.BasicConfiguration GMOCK WARNING: Uninteresting mock function call - returning directly. Function call: Start(0) NOTE: You can safely ignore the above warning unless this call should not happen. Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call. See http://code.google.com/p/googlemock/wiki/CookBook#Knowing_When_to_Expect for details. Stack trace: ../../sync/internal_api/sync_manager_impl_unittest.cc:838: Failure Value of: storage_used_ Actual: 2880154539 Expected: InternalComponentsFactory::STORAGE_ON_DISK Which is: 1 [ FAILED ] SyncManagerTestWithMockScheduler.BasicConfiguration (29 ms) [829/829] SyncManagerTestWithMockScheduler.BasicConfiguration (29 ms) Original issue's description: > Let SyncBackupManager keep backup data in memory until shutdown. Only persist > backup data to disk if shutdown is due to switching to sync. > > BUG=362679 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289709 TBR=zea@chromium.org,haitaol@chromium.org NOTREECHECKS=true NOTRY=true BUG=362679 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289718

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -382 lines) Patch
M chrome/browser/sync/test_profile_sync_service.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M sync/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M sync/internal_api/internal_components_factory_impl.cc View 2 chunks +3 lines, -14 lines 0 comments Download
M sync/internal_api/public/internal_components_factory.h View 2 chunks +0 lines, -16 lines 0 comments Download
M sync/internal_api/public/internal_components_factory_impl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M sync/internal_api/public/test/test_internal_components_factory.h View 3 chunks +12 lines, -5 lines 0 comments Download
M sync/internal_api/sync_backup_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/internal_api/sync_backup_manager.cc View 3 chunks +3 lines, -11 lines 0 comments Download
M sync/internal_api/sync_backup_manager_unittest.cc View 6 chunks +8 lines, -33 lines 0 comments Download
M sync/internal_api/sync_manager_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/internal_api/sync_manager_impl_unittest.cc View 5 chunks +3 lines, -11 lines 0 comments Download
M sync/internal_api/sync_rollback_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M sync/internal_api/sync_rollback_manager_base.h View 3 chunks +3 lines, -5 lines 0 comments Download
M sync/internal_api/sync_rollback_manager_base.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M sync/internal_api/sync_rollback_manager_base_unittest.cc View 2 chunks +1 line, -6 lines 0 comments Download
M sync/internal_api/sync_rollback_manager_unittest.cc View 8 chunks +9 lines, -13 lines 0 comments Download
M sync/internal_api/test/test_internal_components_factory.cc View 4 chunks +4 lines, -15 lines 0 comments Download
M sync/sync.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M sync/sync_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D sync/syncable/deferred_on_disk_directory_backing_store.h View 1 chunk +0 lines, -45 lines 0 comments Download
D sync/syncable/deferred_on_disk_directory_backing_store.cc View 1 chunk +0 lines, -73 lines 0 comments Download
D sync/syncable/deferred_on_disk_directory_backing_store_unittest.cc View 1 chunk +0 lines, -114 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
miu
Created Revert of Let SyncBackupManager keep backup data in memory until shutdown. Only persist
6 years, 4 months ago (2014-08-14 23:05:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miu@chromium.org/477813002/1
6 years, 4 months ago (2014-08-14 23:07:52 UTC) #2
commit-bot: I haz the power
6 years, 4 months ago (2014-08-14 23:11:42 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (1) as 289718

Powered by Google App Engine
This is Rietveld 408576698