Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Issue 477733002: valgrind suppression for zlib Flate Test (Closed)

Created:
6 years, 4 months ago by hal.canary
Modified:
6 years, 4 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

valgrind suppression for zlib Flate Test NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/86cfff0a4d4e082ee8e86af5adb0c7b17cd52e3a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M tools/valgrind.supp View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
hal.canary
ptal
6 years, 4 months ago (2014-08-14 20:05:58 UTC) #1
hal.canary
The CQ bit was checked by halcanary@google.com
6 years, 4 months ago (2014-08-14 20:06:05 UTC) #2
hal.canary
The CQ bit was unchecked by halcanary@google.com
6 years, 4 months ago (2014-08-14 20:06:06 UTC) #3
bsalomon
lgtm
6 years, 4 months ago (2014-08-14 20:06:24 UTC) #4
bsalomon
On 2014/08/14 20:06:24, bsalomon wrote: > lgtm NOTREECHECKS=true?
6 years, 4 months ago (2014-08-14 20:06:48 UTC) #5
hal.canary
The CQ bit was checked by halcanary@google.com
6 years, 4 months ago (2014-08-14 20:08:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/halcanary@google.com/477733002/1
6 years, 4 months ago (2014-08-14 20:08:42 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-14 20:08:50 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (1) as 86cfff0a4d4e082ee8e86af5adb0c7b17cd52e3a

Powered by Google App Engine
This is Rietveld 408576698