DM: add --pipe

dm/DMPipeTask.cpp

+#include "DMPipeTask.h"
+#include "DMUtil.h"
+#include "DMWriteTask.h"
+
+#include "SamplePipeControllers.h"
+#include "SkCommandLineFlags.h"
+#include "SkGPipe.h"
+
+DEFINE_bool(pipe, false, "If true, check several pipe variants against the reference bitmap.");
+
+namespace DM {
+
+static const char* kNames[] = {

[epoger, 2013/10/28 17:42:15]

I see that the indices of these correspond to the values returned by
get_flags(); do we have some way of making sure they stay in sync?

If nothing else, maybe some asserts nearby with a comment indicating why they
are there?  Like so...

// Make sure that the indices of kNames are correct
SkASSERT(1 == SkGPipeWriter::kCrossProcess_Flag);
SkASSERT(2 == SkGPipeWriter::kSharedAddressSpace_Flag);

[mtklein, 2013/10/28 19:03:41]

Added get_name().

+    "pipe",
+    "cross_process_pipe",
+    "shared_address_space_pipe",
+    "cross_process_shared_address_space_pipe",
+};
+
+static uint32_t get_flags(bool crossProcess, bool sharedAddressSpace) {
+    uint32_t flags = 0;
+    if (crossProcess) {
+        flags |= SkGPipeWriter::kCrossProcess_Flag;
+    }
+    if (sharedAddressSpace) {
+        flags |= SkGPipeWriter::kSharedAddressSpace_Flag;
+    }
+    return flags;
+}
+
+PipeTask::PipeTask(const Task& parent,
+                   skiagm::GM* gm,
+                   SkBitmap reference,
+                   bool crossProcess,
+                   bool sharedAddressSpace)
+    : Task(parent)
+    , fFlags(get_flags(crossProcess, sharedAddressSpace))
+    , fName(UnderJoin(parent.name().c_str(), kNames[fFlags]))
+    , fGM(gm)
+    , fReference(reference)
+    {}
+
+void PipeTask::draw() {
+    SkBitmap bitmap;
+    SetupBitmap(fReference.config(), fGM.get(), &bitmap);
+
+    SkCanvas canvas(bitmap);
+    PipeController pipeController(&canvas, &SkImageDecoder::DecodeMemory);
+    SkGPipeWriter writer;
+
+    SkCanvas* pipeCanvas = writer.startRecording(&pipeController,
+                                                 fFlags,
+                                                 bitmap.width(),
+                                                 bitmap.height());
+    pipeCanvas->concat(fGM->getInitialTransform());
+    fGM->draw(pipeCanvas);
+    writer.endRecording();
+
+    if (!BitmapsEqual(bitmap, fReference)) {
+        this->fail();
+        this->spawnChild(SkNEW_ARGS(WriteTask, (*this, bitmap)));
+    }
+}
+
+bool PipeTask::shouldSkip() const {
+    if (!FLAGS_pipe) {
+        return true;
+    }
+    if (fGM->getFlags() & skiagm::GM::kSkipPipe_Flag) {
+        return true;
+    }
+    if (fFlags == SkGPipeWriter::kCrossProcess_Flag &&
+        fGM->getFlags() & skiagm::GM::kSkipPipeCrossProcess_Flag) {
+        return true;
+    }
+    return false;
+}
+
+}  // namespace DM