Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 477723005: Move some extensions renderer tests into extensions_unittests. (Closed)

Created:
6 years, 4 months ago by tfarina
Modified:
6 years, 4 months ago
Reviewers:
James Cook
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, Yoyo Zhou, limasdf
Project:
chromium
Visibility:
Public.

Description

Move some extensions renderer tests into extensions_unittests. BUG=348066, 397166 TEST=extensions_unittests R=jamescook@chromium.org TBR=yoz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290184

Patch Set 1 #

Patch Set 2 : exclude #

Total comments: 2

Patch Set 3 : james' review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M chrome/chrome_tests_unit.gypi View 1 2 2 chunks +0 lines, -3 lines 0 comments Download
M extensions/BUILD.gn View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M extensions/extensions.gyp View 1 2 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
tfarina
6 years, 4 months ago (2014-08-15 03:44:25 UTC) #1
James Cook
LGTM. Hooray, more tests moving to the right place! https://codereview.chromium.org/477723005/diff/20001/extensions/extensions.gyp File extensions/extensions.gyp (right): https://codereview.chromium.org/477723005/diff/20001/extensions/extensions.gyp#newcode893 extensions/extensions.gyp:893: ...
6 years, 4 months ago (2014-08-15 16:25:54 UTC) #2
tfarina
TBRing Yoyo for this (it is trivial). Pushing to CQ. https://codereview.chromium.org/477723005/diff/20001/extensions/extensions.gyp File extensions/extensions.gyp (right): https://codereview.chromium.org/477723005/diff/20001/extensions/extensions.gyp#newcode893 ...
6 years, 4 months ago (2014-08-16 21:45:13 UTC) #3
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 4 months ago (2014-08-16 21:45:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/477723005/40001
6 years, 4 months ago (2014-08-16 21:46:18 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-17 00:43:57 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-17 02:51:51 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/4012)
6 years, 4 months ago (2014-08-17 02:51:52 UTC) #8
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 4 months ago (2014-08-17 03:24:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/477723005/40001
6 years, 4 months ago (2014-08-17 03:25:13 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-17 08:06:33 UTC) #11
commit-bot: I haz the power
6 years, 4 months ago (2014-08-17 17:19:07 UTC) #12
Message was sent while issue was closed. 
Committed patchset #3 (40001) as 290184

Powered by Google App Engine
This is Rietveld 408576698