Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
477723003:
Add ozone_unittests to linux_chromium_chromeos_ozone_{rel,dbg} (Closed)
|
Created:
6 years, 4 months ago by spang Modified:
6 years, 4 months ago Reviewers:
Paweł Hajdan Jr. CC:
chromium-reviews Base URL:
svn://svn.chromium.org/chrome/trunk/src Project:
chromium Visibility:
Public. |
DescriptionAdd ozone_unittests to linux_chromium_chromeos_ozone_{rel,dbg}
BUG=none
TEST=none
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291444
Patch Set 1 #Patch Set 2 : add to trybots, badly #
Total comments: 4
Patch Set 3 : rebase #Patch Set 4 : rebase #
Messages
Total messages: 15 (0 generated)
Also make it run on trybots by modifying chromium_trybot.json (and make sure your change passes trybots).
https://codereview.chromium.org/477723003/diff/20001/testing/buildbot/chromiu... File testing/buildbot/chromium_trybot.json (right): https://codereview.chromium.org/477723003/diff/20001/testing/buildbot/chromiu... testing/buildbot/chromium_trybot.json:200: "chromium_configs": ["chromium_chromeos_ozone"] How do I find out what chromium_configs means? I looked around and it is very unclear. Are there docs?
On 2014/08/15 18:28:50, spang wrote: > https://codereview.chromium.org/477723003/diff/20001/testing/buildbot/chromiu... > File testing/buildbot/chromium_trybot.json (right): > > https://codereview.chromium.org/477723003/diff/20001/testing/buildbot/chromiu... > testing/buildbot/chromium_trybot.json:200: "chromium_configs": > ["chromium_chromeos_ozone"] > How do I find out what chromium_configs means? > > I looked around and it is very unclear. Are there docs? In particular, I need to figure out how to get this to run on the _ozone trybots only. Or equivalently on any bots that set use_ozone=1 in GYP_DEFINES.
https://codereview.chromium.org/477723003/diff/20001/testing/buildbot/chromiu... File testing/buildbot/chromium_trybot.json (right): https://codereview.chromium.org/477723003/diff/20001/testing/buildbot/chromiu... testing/buildbot/chromium_trybot.json:200: "chromium_configs": ["chromium_chromeos_ozone"] On 2014/08/15 18:28:49, spang wrote: > How do I find out what chromium_configs means? > > I looked around and it is very unclear. Are there docs? Please look for should_use_test in chromium_trybot.py . The API is not stable yet. Note that chromium_chromeos_ozone here won't work as such config does not exist.
On 2014/08/18 14:55:00, Paweł Hajdan Jr. wrote: > https://codereview.chromium.org/477723003/diff/20001/testing/buildbot/chromiu... > File testing/buildbot/chromium_trybot.json (right): > > https://codereview.chromium.org/477723003/diff/20001/testing/buildbot/chromiu... > testing/buildbot/chromium_trybot.json:200: "chromium_configs": > ["chromium_chromeos_ozone"] > On 2014/08/15 18:28:49, spang wrote: > > How do I find out what chromium_configs means? > > > > I looked around and it is very unclear. Are there docs? > > Please look for should_use_test in chromium_trybot.py . The API is not stable > yet. > > Note that chromium_chromeos_ozone here won't work as such config does not exist. I figured :). We will have to create it.
https://codereview.chromium.org/477723003/diff/20001/testing/buildbot/chromiu... File testing/buildbot/chromium_trybot.json (right): https://codereview.chromium.org/477723003/diff/20001/testing/buildbot/chromiu... testing/buildbot/chromium_trybot.json:200: "chromium_configs": ["chromium_chromeos_ozone"] On 2014/08/18 14:55:00, Paweł Hajdan Jr. wrote: > On 2014/08/15 18:28:49, spang wrote: > > How do I find out what chromium_configs means? > > > > I looked around and it is very unclear. Are there docs? > > Please look for should_use_test in chromium_trybot.py . The API is not stable > yet. > > Note that chromium_chromeos_ozone here won't work as such config does not exist. This should work now, right?
https://codereview.chromium.org/477723003/diff/20001/testing/buildbot/chromiu... File testing/buildbot/chromium_trybot.json (right): https://codereview.chromium.org/477723003/diff/20001/testing/buildbot/chromiu... testing/buildbot/chromium_trybot.json:200: "chromium_configs": ["chromium_chromeos_ozone"] On 2014/08/20 16:39:22, spang wrote: > This should work now, right? It should. Could you upload a new patchset (to make it easier to review trybot results) and launch tryjobs again?
On 2014/08/20 16:57:12, Paweł Hajdan Jr. wrote: > https://codereview.chromium.org/477723003/diff/20001/testing/buildbot/chromiu... > File testing/buildbot/chromium_trybot.json (right): > > https://codereview.chromium.org/477723003/diff/20001/testing/buildbot/chromiu... > testing/buildbot/chromium_trybot.json:200: "chromium_configs": > ["chromium_chromeos_ozone"] > On 2014/08/20 16:39:22, spang wrote: > > This should work now, right? > > It should. Could you upload a new patchset (to make it easier to review trybot > results) and launch tryjobs again? righto.
On 2014/08/20 17:03:01, spang wrote: > On 2014/08/20 16:57:12, Paweł Hajdan Jr. wrote: > > > https://codereview.chromium.org/477723003/diff/20001/testing/buildbot/chromiu... > > File testing/buildbot/chromium_trybot.json (right): > > > > > https://codereview.chromium.org/477723003/diff/20001/testing/buildbot/chromiu... > > testing/buildbot/chromium_trybot.json:200: "chromium_configs": > > ["chromium_chromeos_ozone"] > > On 2014/08/20 16:39:22, spang wrote: > > > This should work now, right? > > > > It should. Could you upload a new patchset (to make it easier to review trybot > > results) and launch tryjobs again? > > righto. doesn't work yet, since only chromium.chromiumos bots were updated. I posted an new CL for tryserver.chromium.linux
On 2014/08/20 18:15:46, spang wrote: > On 2014/08/20 17:03:01, spang wrote: > > On 2014/08/20 16:57:12, Paweł Hajdan Jr. wrote: > > > > > > https://codereview.chromium.org/477723003/diff/20001/testing/buildbot/chromiu... > > > File testing/buildbot/chromium_trybot.json (right): > > > > > > > > > https://codereview.chromium.org/477723003/diff/20001/testing/buildbot/chromiu... > > > testing/buildbot/chromium_trybot.json:200: "chromium_configs": > > > ["chromium_chromeos_ozone"] > > > On 2014/08/20 16:39:22, spang wrote: > > > > This should work now, right? > > > > > > It should. Could you upload a new patchset (to make it easier to review > trybot > > > results) and launch tryjobs again? > > > > righto. > > doesn't work yet, since only chromium.chromiumos bots were updated. I posted an > new CL for tryserver.chromium.linux working now - http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...
LGTM
The CQ bit was checked by spang@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/477723003/60001
Message was sent while issue was closed.
Committed patchset #4 (60001) as 291444 |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
