Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 477663004: Merged FakedDBusThreadManager with DBusThreadManager. (Closed)

Created:
6 years, 4 months ago by zel
Modified:
6 years, 3 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, derat+watch_chromium.org, Ilya Sherman, asvitkine+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, markusheintz_, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, satorux1
Project:
chromium
Visibility:
Public.

Description

Part 3: Merged FakedDBusThreadManager with DBusThreadManager. BUG=401192 TEST=existing tests TBR=sky,stevenjb,keybuk Committed: https://crrev.com/29fe338316a08c2669d2e011889dff2b91dfb616 Cr-Commit-Position: refs/heads/master@{#292072}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : rebase #

Patch Set 6 : #

Patch Set 7 : #

Total comments: 22

Patch Set 8 : #

Patch Set 9 : Removed DBusThreadManagerImpl class #

Patch Set 10 : #

Patch Set 11 : #

Patch Set 12 : #

Patch Set 13 : #

Total comments: 26

Patch Set 14 : #

Patch Set 15 : #

Patch Set 16 : #

Patch Set 17 : #

Patch Set 18 : #

Patch Set 19 : #

Patch Set 20 : #

Total comments: 6

Patch Set 21 : #

Patch Set 22 : #

Patch Set 23 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+745 lines, -1255 lines) Patch
M ash/display/projecting_observer_chromeos_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +2 lines, -7 lines 0 comments Download
M ash/system/chromeos/network/network_state_notifier_unittest.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/power/power_status_unittest.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M ash/test/ash_test_helper.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M athena/test/athena_test_helper.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/apps/app_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 2 chunks +1 line, -6 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_remover_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/customization_document_unittest.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/auth/cryptohome_authenticator_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/crash_restore_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/lock/screen_locker_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/reset_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +5 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/saml/saml_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 3 chunks +4 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/login/screens/network_screen_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/screens/update_screen_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/users/avatar/user_image_manager_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 3 chunks +3 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/login/users/user_manager_unittest.cc View 1 2 3 4 5 6 7 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_policy_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 4 chunks +3 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +1 line, -6 lines 0 comments Download
M chrome/browser/chromeos/mobile/mobile_activator_unittest.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/net/network_portal_detector_impl_unittest.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_cloud_policy_invalidator_unittest.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/policy/device_policy_cros_browser_test.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/policy/device_policy_cros_browser_test.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 2 chunks +5 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/policy/device_status_collector_browsertest.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/enterprise_install_attributes_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/power_policy_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/power/peripheral_battery_observer_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/power/power_data_collector_unittest.cc View 1 2 3 4 5 6 7 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/chromeos/power/power_prefs_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 3 chunks +11 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/proxy_config_service_impl_unittest.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/settings/device_oauth2_token_service_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_test_helper.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_test_helper.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 3 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/system/automatic_reboot_manager_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/image_writer_private/test_utils.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +3 lines, -13 lines 0 comments Download
M chrome/browser/extensions/api/log_private/log_private_apitest_chromeos.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 2 chunks +2 lines, -7 lines 0 comments Download
M chrome/browser/extensions/api/system_private/system_private_apitest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +2 lines, -7 lines 0 comments Download
M chrome/browser/metrics/chromeos_metrics_provider_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 5 chunks +12 lines, -14 lines 0 comments Download
M chrome/test/base/testing_io_thread_state.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/view_event_test_platform_part_chromeos.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M chromeos/audio/cras_audio_handler_unittest.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M chromeos/chromeos.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -2 lines 0 comments Download
M chromeos/cryptohome/system_salt_getter_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +2 lines, -4 lines 0 comments Download
M chromeos/dbus/dbus_client.h View 1 2 3 4 5 6 7 8 2 chunks +2 lines, -2 lines 0 comments Download
M chromeos/dbus/dbus_client_bundle.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 2 chunks +3 lines, -1 line 0 comments Download
M chromeos/dbus/dbus_client_bundle.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/dbus_thread_manager.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 3 chunks +120 lines, -67 lines 0 comments Download
M chromeos/dbus/dbus_thread_manager.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 8 chunks +439 lines, -267 lines 0 comments Download
D chromeos/dbus/fake_dbus_thread_manager.h View 1 chunk +0 lines, -167 lines 0 comments Download
D chromeos/dbus/fake_dbus_thread_manager.cc View 1 chunk +0 lines, -472 lines 0 comments Download
M chromeos/dbus/fake_shill_manager_client.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 1 chunk +5 lines, -0 lines 0 comments Download
M chromeos/dbus/power_policy_controller_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 3 chunks +6 lines, -6 lines 0 comments Download
M chromeos/disks/disk_mount_manager_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 3 chunks +2 lines, -6 lines 0 comments Download
M chromeos/network/client_cert_resolver_unittest.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/geolocation_handler_unittest.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/host_resolver_impl_chromeos_unittest.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/managed_network_configuration_handler_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +4 lines, -6 lines 0 comments Download
M chromeos/network/network_cert_migrator_unittest.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/network_configuration_handler_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 4 chunks +6 lines, -8 lines 0 comments Download
M chromeos/network/network_connection_handler_unittest.cc View 1 2 3 4 5 6 7 2 chunks +3 lines, -4 lines 0 comments Download
M chromeos/network/network_device_handler_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +2 lines, -6 lines 0 comments Download
M chromeos/network/network_sms_handler_unittest.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/network_state_handler_unittest.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/shill_property_handler_unittest.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M content/browser/geolocation/wifi_data_provider_chromeos_unittest.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/bluetooth_chromeos_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +8 lines, -8 lines 0 comments Download
M device/bluetooth/bluetooth_gatt_chromeos_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 4 chunks +10 lines, -10 lines 0 comments Download
M device/bluetooth/bluetooth_socket_chromeos_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +9 lines, -10 lines 0 comments Download
M device/nfc/nfc_chromeos_unittest.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M extensions/shell/browser/shell_desktop_controller_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 27 (0 generated)
zel
...and the last part of that refactoring story...
6 years, 4 months ago (2014-08-15 01:33:57 UTC) #1
hashimoto
On 2014/08/15 01:33:57, zel wrote: > ...and the last part of that refactoring story... It ...
6 years, 4 months ago (2014-08-15 01:41:26 UTC) #2
zel
On 2014/08/15 01:41:26, hashimoto wrote: > On 2014/08/15 01:33:57, zel wrote: > > ...and the ...
6 years, 4 months ago (2014-08-15 01:43:03 UTC) #3
zel
On 2014/08/15 01:43:03, zel wrote: > On 2014/08/15 01:41:26, hashimoto wrote: > > On 2014/08/15 ...
6 years, 4 months ago (2014-08-15 21:20:47 UTC) #4
hashimoto
https://codereview.chromium.org/477663004/diff/120001/chromeos/dbus/dbus_client.h File chromeos/dbus/dbus_client.h (right): https://codereview.chromium.org/477663004/diff/120001/chromeos/dbus/dbus_client.h#newcode21 chromeos/dbus/dbus_client.h:21: friend class DBusThreadManager; Do we need this now? https://codereview.chromium.org/477663004/diff/120001/chromeos/dbus/dbus_thread_manager.cc ...
6 years, 4 months ago (2014-08-18 04:55:59 UTC) #5
zel
https://codereview.chromium.org/477663004/diff/120001/chromeos/dbus/dbus_client.h File chromeos/dbus/dbus_client.h (right): https://codereview.chromium.org/477663004/diff/120001/chromeos/dbus/dbus_client.h#newcode21 chromeos/dbus/dbus_client.h:21: friend class DBusThreadManager; On 2014/08/18 04:55:58, hashimoto wrote: > ...
6 years, 4 months ago (2014-08-18 23:41:52 UTC) #6
hashimoto
https://codereview.chromium.org/477663004/diff/120001/chromeos/dbus/dbus_thread_manager.h File chromeos/dbus/dbus_thread_manager.h (right): https://codereview.chromium.org/477663004/diff/120001/chromeos/dbus/dbus_thread_manager.h#newcode97 chromeos/dbus/dbus_thread_manager.h:97: static scoped_ptr<DBusThreadManagerTestHelper> InitializeForTesting(); On 2014/08/18 23:41:52, zel wrote: > ...
6 years, 4 months ago (2014-08-19 02:31:58 UTC) #7
zel
https://codereview.chromium.org/477663004/diff/120001/chromeos/dbus/dbus_thread_manager.h File chromeos/dbus/dbus_thread_manager.h (right): https://codereview.chromium.org/477663004/diff/120001/chromeos/dbus/dbus_thread_manager.h#newcode97 chromeos/dbus/dbus_thread_manager.h:97: static scoped_ptr<DBusThreadManagerTestHelper> InitializeForTesting(); On 2014/08/19 02:31:58, hashimoto wrote: > ...
6 years, 4 months ago (2014-08-19 04:44:39 UTC) #8
hashimoto
https://codereview.chromium.org/477663004/diff/120001/chromeos/dbus/dbus_thread_manager.h File chromeos/dbus/dbus_thread_manager.h (right): https://codereview.chromium.org/477663004/diff/120001/chromeos/dbus/dbus_thread_manager.h#newcode97 chromeos/dbus/dbus_thread_manager.h:97: static scoped_ptr<DBusThreadManagerTestHelper> InitializeForTesting(); On 2014/08/19 04:44:39, zel wrote: > ...
6 years, 4 months ago (2014-08-19 05:11:59 UTC) #9
zel
I have also fuzed DBusThreadManagerImpl with DBusThreadManager class https://codereview.chromium.org/477663004/diff/120001/chromeos/dbus/dbus_thread_manager.h File chromeos/dbus/dbus_thread_manager.h (right): https://codereview.chromium.org/477663004/diff/120001/chromeos/dbus/dbus_thread_manager.h#newcode97 chromeos/dbus/dbus_thread_manager.h:97: static ...
6 years, 4 months ago (2014-08-22 22:24:18 UTC) #10
hashimoto
cc: satorux FYI https://codereview.chromium.org/477663004/diff/120001/chromeos/dbus/dbus_thread_manager.h File chromeos/dbus/dbus_thread_manager.h (right): https://codereview.chromium.org/477663004/diff/120001/chromeos/dbus/dbus_thread_manager.h#newcode97 chromeos/dbus/dbus_thread_manager.h:97: static scoped_ptr<DBusThreadManagerTestHelper> InitializeForTesting(); On 2014/08/22 22:24:18, ...
6 years, 4 months ago (2014-08-25 06:56:20 UTC) #11
zel
https://codereview.chromium.org/477663004/diff/120001/chromeos/dbus/dbus_thread_manager.h File chromeos/dbus/dbus_thread_manager.h (right): https://codereview.chromium.org/477663004/diff/120001/chromeos/dbus/dbus_thread_manager.h#newcode97 chromeos/dbus/dbus_thread_manager.h:97: static scoped_ptr<DBusThreadManagerTestHelper> InitializeForTesting(); On 2014/08/25 06:56:19, hashimoto wrote: > ...
6 years, 4 months ago (2014-08-25 17:21:43 UTC) #12
Daniel Erat
https://codereview.chromium.org/477663004/diff/240001/chromeos/dbus/dbus_thread_manager.cc File chromeos/dbus/dbus_thread_manager.cc (right): https://codereview.chromium.org/477663004/diff/240001/chromeos/dbus/dbus_thread_manager.cc#newcode616 chromeos/dbus/dbus_thread_manager.cc:616: scoped_ptr<PowerManagerClient> client) { On 2014/08/25 17:21:42, zel wrote: > ...
6 years, 4 months ago (2014-08-25 17:28:25 UTC) #13
zel
https://codereview.chromium.org/477663004/diff/240001/chromeos/dbus/dbus_thread_manager.cc File chromeos/dbus/dbus_thread_manager.cc (right): https://codereview.chromium.org/477663004/diff/240001/chromeos/dbus/dbus_thread_manager.cc#newcode113 chromeos/dbus/dbus_thread_manager.cc:113: DBusThreadManager* DBusThreadManager::CreateInstance() { On 2014/08/25 17:21:42, zel wrote: > ...
6 years, 3 months ago (2014-08-25 20:19:47 UTC) #14
hashimoto
lgtm thanks https://codereview.chromium.org/477663004/diff/240001/chromeos/dbus/dbus_thread_manager.cc File chromeos/dbus/dbus_thread_manager.cc (right): https://codereview.chromium.org/477663004/diff/240001/chromeos/dbus/dbus_thread_manager.cc#newcode616 chromeos/dbus/dbus_thread_manager.cc:616: scoped_ptr<PowerManagerClient> client) { On 2014/08/25 17:28:25, Daniel ...
6 years, 3 months ago (2014-08-26 01:55:00 UTC) #15
Daniel Erat
https://codereview.chromium.org/477663004/diff/240001/chromeos/dbus/dbus_thread_manager.cc File chromeos/dbus/dbus_thread_manager.cc (right): https://codereview.chromium.org/477663004/diff/240001/chromeos/dbus/dbus_thread_manager.cc#newcode616 chromeos/dbus/dbus_thread_manager.cc:616: scoped_ptr<PowerManagerClient> client) { On 2014/08/26 01:54:59, hashimoto wrote: > ...
6 years, 3 months ago (2014-08-26 16:08:04 UTC) #16
zel
https://codereview.chromium.org/477663004/diff/240001/chromeos/dbus/dbus_thread_manager.cc File chromeos/dbus/dbus_thread_manager.cc (right): https://codereview.chromium.org/477663004/diff/240001/chromeos/dbus/dbus_thread_manager.cc#newcode616 chromeos/dbus/dbus_thread_manager.cc:616: scoped_ptr<PowerManagerClient> client) { On 2014/08/26 16:08:03, Daniel Erat wrote: ...
6 years, 3 months ago (2014-08-26 17:50:46 UTC) #17
zel
The CQ bit was checked by zelidrag@chromium.org
6 years, 3 months ago (2014-08-26 17:52:52 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zelidrag@chromium.org/477663004/420001
6 years, 3 months ago (2014-08-26 17:54:23 UTC) #19
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux ...
6 years, 3 months ago (2014-08-26 19:48:14 UTC) #20
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-26 22:42:52 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/8137)
6 years, 3 months ago (2014-08-26 22:42:54 UTC) #22
zel
The CQ bit was checked by zelidrag@chromium.org
6 years, 3 months ago (2014-08-27 00:09:43 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zelidrag@chromium.org/477663004/440001
6 years, 3 months ago (2014-08-27 00:11:49 UTC) #24
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_compile_dbg on tryserver.chromium.mac ...
6 years, 3 months ago (2014-08-27 01:33:35 UTC) #25
commit-bot: I haz the power
Committed patchset #23 (440001) as 5cd3d5b962b80197b4d641cc215d2cd2e91bfa74
6 years, 3 months ago (2014-08-27 01:45:05 UTC) #26
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:48:54 UTC) #27
Message was sent while issue was closed.
Patchset 23 (id:??) landed as
https://crrev.com/29fe338316a08c2669d2e011889dff2b91dfb616
Cr-Commit-Position: refs/heads/master@{#292072}

Powered by Google App Engine
This is Rietveld 408576698