Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Unified Diff: content/browser/geolocation/network_location_request.cc

Issue 477633002: Rename various Geolocation bits for clarity and consistency. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: One more rename. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/geolocation/network_location_request.cc
diff --git a/content/browser/geolocation/network_location_request.cc b/content/browser/geolocation/network_location_request.cc
index 75c7c8434f4d281112cff9d9bf4804ff0f2d5436..84ba5b05edcc5dd1b333feee72c9190218af8735 100644
--- a/content/browser/geolocation/network_location_request.cc
+++ b/content/browser/geolocation/network_location_request.cc
@@ -103,9 +103,7 @@ NetworkLocationRequest::NetworkLocationRequest(
net::URLRequestContextGetter* context,
const GURL& url,
LocationResponseCallback callback)
- : url_context_(context),
- callback_(callback),
- url_(url) {
+ : url_context_(context), location_response_callback_(callback), url_(url) {
}
NetworkLocationRequest::~NetworkLocationRequest() {
@@ -122,7 +120,7 @@ bool NetworkLocationRequest::MakeRequest(const base::string16& access_token,
url_fetcher_.reset();
}
wifi_data_ = wifi_data;
- timestamp_ = timestamp;
+ wifi_data_timestamp_ = timestamp;
GURL request_url = FormRequestURL(url_);
url_fetcher_.reset(net::URLFetcher::Create(
@@ -136,7 +134,7 @@ bool NetworkLocationRequest::MakeRequest(const base::string16& access_token,
net::LOAD_DO_NOT_SAVE_COOKIES | net::LOAD_DO_NOT_SEND_COOKIES |
net::LOAD_DO_NOT_SEND_AUTH_DATA);
- start_time_ = base::TimeTicks::Now();
+ request_start_time_ = base::TimeTicks::Now();
url_fetcher_->Start();
return true;
}
@@ -156,7 +154,7 @@ void NetworkLocationRequest::OnURLFetchComplete(
GetLocationFromResponse(status.is_success(),
response_code,
data,
- timestamp_,
+ wifi_data_timestamp_,
source->GetURL(),
&position,
&access_token);
@@ -165,7 +163,8 @@ void NetworkLocationRequest::OnURLFetchComplete(
url_fetcher_.reset();
if (!server_error) {
- const base::TimeDelta request_time = base::TimeTicks::Now() - start_time_;
+ const base::TimeDelta request_time =
+ base::TimeTicks::Now() - request_start_time_;
UMA_HISTOGRAM_CUSTOM_TIMES(
"Net.Wifi.LbsLatency",
@@ -176,7 +175,8 @@ void NetworkLocationRequest::OnURLFetchComplete(
}
DVLOG(1) << "NetworkLocationRequest::OnURLFetchComplete() : run callback.";
- callback_.Run(position, server_error, access_token, wifi_data_);
+ location_response_callback_.Run(
+ position, server_error, access_token, wifi_data_);
}
// Local functions.

Powered by Google App Engine
This is Rietveld 408576698