Video Player: Hide the cast icon on non-drive volume

Video Player: Hide the cast icon on non-drive volume

BUG=402931
TEST=manually tested

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289608

[yoshiki, 2014-08-14 08:22:35]

@hirono, PTAL. Thanks.

[hirono, 2014-08-14 09:37:18]

https://codereview.chromium.org/477603002/diff/1/ui/file_manager/video_player...
File ui/file_manager/video_player/js/video_player.js (left):

https://codereview.chromium.org/477603002/diff/1/ui/file_manager/video_player...
ui/file_manager/video_player/js/video_player.js:308: var media = new
MediaManager(video.entry);
Is it OK to remove this line?

https://codereview.chromium.org/477603002/diff/1/ui/file_manager/video_player...
File ui/file_manager/video_player/js/video_player.js (right):

https://codereview.chromium.org/477603002/diff/1/ui/file_manager/video_player...
ui/file_manager/video_player/js/video_player.js:343:
media.isAvailableForCast().then(function(result) {
Can we assign the return value to videoElementInitializePromise?

[yoshiki, 2014-08-14 10:17:44]

@hirono, PTAL.

https://codereview.chromium.org/477603002/diff/1/ui/file_manager/video_player...
File ui/file_manager/video_player/js/video_player.js (left):

https://codereview.chromium.org/477603002/diff/1/ui/file_manager/video_player...
ui/file_manager/video_player/js/video_player.js:308: var media = new
MediaManager(video.entry);
On 2014/08/14 09:37:18, hirono wrote:
> Is it OK to remove this line?

This is a dup with L295.

https://codereview.chromium.org/477603002/diff/1/ui/file_manager/video_player...
File ui/file_manager/video_player/js/video_player.js (right):

https://codereview.chromium.org/477603002/diff/1/ui/file_manager/video_player...
ui/file_manager/video_player/js/video_player.js:343:
media.isAvailableForCast().then(function(result) {
On 2014/08/14 09:37:18, hirono wrote:
> Can we assign the return value to videoElementInitializePromise?

I don't think this block the initialization. It just changes the status of cast
icon.

[hirono, 2014-08-14 10:35:47]

lgtm with a nit.

https://codereview.chromium.org/477603002/diff/1/ui/file_manager/video_player...
File ui/file_manager/video_player/js/video_player.js (right):

https://codereview.chromium.org/477603002/diff/1/ui/file_manager/video_player...
ui/file_manager/video_player/js/video_player.js:343:
media.isAvailableForCast().then(function(result) {
On 2014/08/14 10:17:43, yoshiki wrote:
> On 2014/08/14 09:37:18, hirono wrote:
> > Can we assign the return value to videoElementInitializePromise?
> 
> I don't think this block the initialization. It just changes the status of
cast
> icon.

SGTM. So please add an error handler after then.

[yoshiki, 2014-08-14 10:52:13]

Thanks.

https://codereview.chromium.org/477603002/diff/1/ui/file_manager/video_player...
File ui/file_manager/video_player/js/video_player.js (right):

https://codereview.chromium.org/477603002/diff/1/ui/file_manager/video_player...
ui/file_manager/video_player/js/video_player.js:343:
media.isAvailableForCast().then(function(result) {
On 2014/08/14 10:35:47, hirono wrote:
> On 2014/08/14 10:17:43, yoshiki wrote:
> > On 2014/08/14 09:37:18, hirono wrote:
> > > Can we assign the return value to videoElementInitializePromise?
> > 
> > I don't think this block the initialization. It just changes the status of
> cast
> > icon.
> 
> SGTM. So please add an error handler after then.

Done.

[yoshiki, 2014-08-14 10:52:16]

The CQ bit was checked by yoshiki@chromium.org

[commit-bot: I haz the power, 2014-08-14 10:53:50]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/yoshiki@chromium.org/477603002/20001

[commit-bot: I haz the power, 2014-08-14 15:57:14]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[commit-bot: I haz the power, 2014-08-14 16:08:24]

Committed patchset #2 (20001) as 289608