Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issue 477593005: DevTools: [SSP] live-update property value when it's selected via mouse. (Closed)

Created:
6 years, 4 months ago by lushnikov
Modified:
6 years, 4 months ago
Reviewers:
apavlov, vsevik
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: [SSP] live-update property value when it's selected via mouse. There was a left-over condition in the TextPrompt which has never being satisfied. As a result, the WebInspector.TextPrompt.Events.ItemAccepted event has never being fired. BUG=398224 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180453

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M Source/devtools/front_end/ui/TextPrompt.js View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
lushnikov
ptal
6 years, 4 months ago (2014-08-16 17:29:30 UTC) #1
apavlov
The CQ bit was checked by apavlov@chromium.org
6 years, 4 months ago (2014-08-18 11:25:09 UTC) #2
apavlov
lgtm
6 years, 4 months ago (2014-08-18 11:25:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/477593005/1
6 years, 4 months ago (2014-08-18 11:26:17 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-18 12:29:52 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-18 12:59:03 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (1) as 180453

Powered by Google App Engine
This is Rietveld 408576698