[fsp] Add a method to enumerate all mounted file systems.

[fsp] Add a method to enumerate all mounted file systems.

Since provided file systems are persistent and they are automatically remounted
after a reboot, providing extensions may want to know which file systems are
actually in use.

Before, providing extensions had to keep list of mounted file systems in local
storage, which was problematic and could end up on being out of sync in case
of crashes.

This patch introduces a getAll() method which can be used to get a list of
mounted file systems by the provider executing it.

TEST=browser_tests: *FileSystemProvider*GetAll*
BUG=393156
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290232

[mtomasz, 2014-08-14 07:29:32]

@benwells: PTAL at IDL.
@hirono: PTAL at JS and C++.
@isherman: PTAL as histograms.

Thanks.

[Ilya Sherman, 2014-08-14 07:32:51]

histograms lgtm

[hirono, 2014-08-14 11:45:32]

https://codereview.chromium.org/477583002/diff/20001/chrome/browser/chromeos/...
File
chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc
(right):

https://codereview.chromium.org/477583002/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc:108:
scoped_ptr<FileSystemInfo> item(new FileSystemInfo);
How about turning it to linked_ptr. We can push it to the vector directly.

[benwells, 2014-08-15 01:31:57]

lgtm. Just some questions you can do what you want with.

Before we release this to stable the API proposal will need to be updated and
re-reviewed as I think it has changed.

https://codereview.chromium.org/477583002/diff/20001/chrome/common/extensions...
File chrome/common/extensions/api/file_system_provider.idl (right):

https://codereview.chromium.org/477583002/diff/20001/chrome/common/extensions...
chrome/common/extensions/api/file_system_provider.idl:57: dictionary
FileSystemInfo {
Could this ever clash with unmounted file systems? i.e. would a better name be
MountedFileSystemInfo?

https://codereview.chromium.org/477583002/diff/20001/chrome/common/extensions...
chrome/common/extensions/api/file_system_provider.idl:237: static void
getAll(GetAllCallback callback);
Not sure if this name is too vague. Consider getAllMounted or
getAllMountedFileSystems.

[mtomasz, 2014-08-15 03:36:03]

@benwells: Yep, I agree we'll need to update the doc and re-review it, before
shipping.

https://codereview.chromium.org/477583002/diff/20001/chrome/browser/chromeos/...
File
chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc
(right):

https://codereview.chromium.org/477583002/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc:108:
scoped_ptr<FileSystemInfo> item(new FileSystemInfo);
On 2014/08/14 11:45:32, hirono wrote:
> How about turning it to linked_ptr. We can push it to the vector directly.

Done.

https://codereview.chromium.org/477583002/diff/20001/chrome/common/extensions...
File chrome/common/extensions/api/file_system_provider.idl (right):

https://codereview.chromium.org/477583002/diff/20001/chrome/common/extensions...
chrome/common/extensions/api/file_system_provider.idl:57: dictionary
FileSystemInfo {
On 2014/08/15 01:31:57, benwells wrote:
> Could this ever clash with unmounted file systems? i.e. would a better name be
> MountedFileSystemInfo?

Hm. Basically unmounted file systems do not exist. File systems are created when
mounted, and once  umounted they are removed.

I'm fine with either naming. Let me know if you still prefer
MountedFileSystemInfo.

https://codereview.chromium.org/477583002/diff/20001/chrome/common/extensions...
chrome/common/extensions/api/file_system_provider.idl:237: static void
getAll(GetAllCallback callback);
On 2014/08/15 01:31:57, benwells wrote:
> Not sure if this name is too vague. Consider getAllMounted or
> getAllMountedFileSystems.

I followed the pattern as in other apis:
https://developer.chrome.com/extensions/windows#method-getAll
https://developer.chrome.com/extensions/notifications#method-getAll
https://developer.chrome.com/extensions/cookies#method-getAll
https://developer.chrome.com/extensions/management#method-getAll
etc.

[hirono, 2014-08-15 03:39:45]

On 2014/08/15 03:36:03, mtomasz wrote:
> @benwells: Yep, I agree we'll need to update the doc and re-review it, before
> shipping.
> 
>
https://codereview.chromium.org/477583002/diff/20001/chrome/browser/chromeos/...
> File
>
chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc
> (right):
> 
>
https://codereview.chromium.org/477583002/diff/20001/chrome/browser/chromeos/...
>
chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc:108:
> scoped_ptr<FileSystemInfo> item(new FileSystemInfo);
> On 2014/08/14 11:45:32, hirono wrote:
> > How about turning it to linked_ptr. We can push it to the vector directly.
> 
> Done.
> 
>
https://codereview.chromium.org/477583002/diff/20001/chrome/common/extensions...
> File chrome/common/extensions/api/file_system_provider.idl (right):
> 
>
https://codereview.chromium.org/477583002/diff/20001/chrome/common/extensions...
> chrome/common/extensions/api/file_system_provider.idl:57: dictionary
> FileSystemInfo {
> On 2014/08/15 01:31:57, benwells wrote:
> > Could this ever clash with unmounted file systems? i.e. would a better name
be
> > MountedFileSystemInfo?
> 
> Hm. Basically unmounted file systems do not exist. File systems are created
when
> mounted, and once  umounted they are removed.
> 
> I'm fine with either naming. Let me know if you still prefer
> MountedFileSystemInfo.
> 
>
https://codereview.chromium.org/477583002/diff/20001/chrome/common/extensions...
> chrome/common/extensions/api/file_system_provider.idl:237: static void
> getAll(GetAllCallback callback);
> On 2014/08/15 01:31:57, benwells wrote:
> > Not sure if this name is too vague. Consider getAllMounted or
> > getAllMountedFileSystems.
> 
> I followed the pattern as in other apis:
> https://developer.chrome.com/extensions/windows#method-getAll
> https://developer.chrome.com/extensions/notifications#method-getAll
> https://developer.chrome.com/extensions/cookies#method-getAll
> https://developer.chrome.com/extensions/management#method-getAll
> etc.

lgtm! for *.cc, *.h, *.js

[mtomasz, 2014-08-18 08:26:49]

The CQ bit was checked by mtomasz@chromium.org

[commit-bot: I haz the power, 2014-08-18 08:27:56]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mtomasz@chromium.org/477583002/60001

[commit-bot: I haz the power, 2014-08-18 09:40:33]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_trigger...)

[commit-bot: I haz the power, 2014-08-18 10:06:42]

Committed patchset #4 (60001) as 290232