Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 47753003: Fix build for xcodebuild from Xcode 5 (Closed)

Created:
7 years, 1 month ago by Mark Mentovai
Modified:
7 years, 1 month ago
Reviewers:
Nico
CC:
chromium-reviews, Jiang Jiang
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix build for xcodebuild from Xcode 5: - In Xcode 5, ARCHS defaults to x86_64 instead of i386. Use i386 for the 32-bit Chrome build. - In Xcode 5, otool is no longer available in DEVELOPER_BIN_DIR. Run otool via xcrun as in r227787. BUG=280362 R=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232181

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M build/common.gypi View 1 1 chunk +5 lines, -0 lines 0 comments Download
M build/mac/verify_no_objc.sh View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mark Mentovai
As much as we don’t really care about building Chrome with Xcode anymore, this doesn’t ...
7 years, 1 month ago (2013-10-31 16:34:01 UTC) #1
Nico
lgtm!
7 years, 1 month ago (2013-10-31 16:54:07 UTC) #2
Mark Mentovai
7 years, 1 month ago (2013-10-31 18:40:04 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r232181 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698