Athena: Adding basic resource management framework (un-/re-loading) of V2 applications

athena/content/app_activity.h

Index: athena/content/app_activity.h
diff --git a/athena/content/app_activity.h b/athena/content/app_activity.h
index 4f6ef2b3d47ac45d05805aaf02fe053feea03930..9b9f08b1d049b92adc30852e0552094c389a0d18 100644
--- a/athena/content/app_activity.h
+++ b/athena/content/app_activity.h
@@ -2,8 +2,8 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef ATHENA_CONTENT_PUBLIC_APP_ACTIVITY_H_
-#define ATHENA_CONTENT_PUBLIC_APP_ACTIVITY_H_
+#ifndef ATHENA_CONTENT_APP_ACTIVITY_H_
+#define ATHENA_CONTENT_APP_ACTIVITY_H_
 
 #include "athena/activity/public/activity.h"
 #include "athena/activity/public/activity_view_model.h"
@@ -20,6 +20,9 @@ class WebView;
 
 namespace athena {
 
+class AppActivityRegistry;
+
+// The activity object for a hosted V2 application.
 class AppActivity : public Activity,
                     public ActivityViewModel,
                     public content::WebContentsObserver {
@@ -27,13 +30,13 @@ class AppActivity : public Activity,
   explicit AppActivity(extensions::ShellAppWindow* app_window);
   virtual ~AppActivity();
 
- protected:
   // Activity:
   virtual athena::ActivityViewModel* GetActivityViewModel() OVERRIDE;
   virtual void SetCurrentState(Activity::ActivityState state) OVERRIDE;
   virtual ActivityState GetCurrentState() OVERRIDE;
   virtual bool IsVisible() OVERRIDE;
   virtual ActivityMediaState GetMediaState() OVERRIDE;
+  virtual aura::Window* GetWindow() OVERRIDE;
 
   // ActivityViewModel:
   virtual void Init() OVERRIDE;
@@ -44,13 +47,20 @@ class AppActivity : public Activity,
   virtual void CreateOverviewModeImage() OVERRIDE;
   virtual gfx::ImageSkia GetOverviewModeImage() OVERRIDE;
 
+ protected:
   // content::WebContentsObserver:
   virtual void TitleWasSet(content::NavigationEntry* entry,
                            bool explicit_set) OVERRIDE;
   virtual void DidUpdateFaviconURL(
       const std::vector<content::FaviconURL>& candidates) OVERRIDE;
+  virtual void DidStartNavigationToPendingEntry(
+        const GURL& url,
+        content::NavigationController::ReloadType reload_type) OVERRIDE;
 
  private:
+  // Register this activity with its application.
+  void RegisterActivity();
+
   scoped_ptr<extensions::ShellAppWindow> app_window_;
   views::WebView* web_view_;
 
@@ -60,6 +70,9 @@ class AppActivity : public Activity,
   // The image which will be used in overview mode.
   gfx::ImageSkia overview_mode_image_;
 
+  // If known the registry which holds all activities for the associated app.

[oshima, 2014/08/19 21:22:24]

plase document ownership / lifetime

[Mr4D (OOO till 08-26), 2014/08/20 14:34:39]

Done.

+  AppActivityRegistry* app_activity_registry_;
+
   DISALLOW_COPY_AND_ASSIGN(AppActivity);
 };