Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Unified Diff: cc/trees/layer_tree_host_unittest.cc

Issue 477443002: Enable test LayerTreeHostTestBreakSwapPromise with verbose logging information (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/trees/layer_tree_host_unittest.cc
diff --git a/cc/trees/layer_tree_host_unittest.cc b/cc/trees/layer_tree_host_unittest.cc
index 453c75cb54daa5ae60dd8a7965dc20ac6e0ebc3c..2f9a5a549d63660dc9328fa9324d682fefed7e1a 100644
--- a/cc/trees/layer_tree_host_unittest.cc
+++ b/cc/trees/layer_tree_host_unittest.cc
@@ -4468,11 +4468,19 @@ class TestSwapPromise : public SwapPromise {
virtual ~TestSwapPromise() {
base::AutoLock lock(result_->lock);
+ LOG(INFO) << "~TestSwapPromise() "
danakj 2014/08/13 23:09:07 i suggest LOG(ERROR), maybe this works too but i'v
Yufeng Shen (Slow to review) 2014/08/13 23:25:58 Done.
+ << " did_swap_called " << result_->did_swap_called
+ << " did_not_swap_called " << result_->did_not_swap_called
+ << " result addr " << result_;
result_->dtor_called = true;
}
virtual void DidSwap(CompositorFrameMetadata* metadata) OVERRIDE {
base::AutoLock lock(result_->lock);
+ LOG(INFO) << "TestSwapPromise::DidSwap "
+ << " did_swap_called " << result_->did_swap_called
+ << " did_not_swap_called " << result_->did_not_swap_called
+ << " result addr " << result_;
EXPECT_FALSE(result_->did_swap_called);
EXPECT_FALSE(result_->did_not_swap_called);
result_->did_swap_called = true;
@@ -4480,6 +4488,11 @@ class TestSwapPromise : public SwapPromise {
virtual void DidNotSwap(DidNotSwapReason reason) OVERRIDE {
base::AutoLock lock(result_->lock);
+ LOG(INFO) << "TestSwapPromise::DidNotSwap "
+ << " reason " << reason
+ << " did_swap_called " << result_->did_swap_called
+ << " did_not_swap_called " << result_->did_not_swap_called
+ << " result addr " << result_;
EXPECT_FALSE(result_->did_swap_called);
EXPECT_FALSE(result_->did_not_swap_called);
result_->did_not_swap_called = true;
@@ -4563,7 +4576,8 @@ class LayerTreeHostTestBreakSwapPromise : public LayerTreeHostTest {
};
// TODO(miletus): Flaky test: crbug.com/393995
-// MULTI_THREAD_TEST_F(LayerTreeHostTestBreakSwapPromise);
+// Enabled with verbose logging information.
+MULTI_THREAD_TEST_F(LayerTreeHostTestBreakSwapPromise);
class LayerTreeHostTestBreakSwapPromiseForVisibilityAbortedCommit
: public LayerTreeHostTest {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698