Enable test LayerTreeHostTestBreakSwapPromise with verbose logging information

Enable test LayerTreeHostTestBreakSwapPromise with verbose logging information

The log of the flaky LayerTreeHostTestBreakSwapPromise test shows that

[ RUN      ] LayerTreeHostTestBreakSwapPromise.RunMultiThread_DelegatingRenderer_ImplSidePaint
c:\b\build\slave\win_x64_builder\build\src\cc\trees\layer_tree_host_unittest.cc(4500): error: Value of: swap_promise_result_[2].did_not_swap_called
Actual: false
Expected: true
c:\b\build\slave\win_x64_builder\build\src\cc\trees\layer_tree_host_unittest.cc(4501): error: Value of: swap_promise_result_[2].reason
Actual: 0
Expected: SwapPromise::SWAP_FAILS
Which is: 1
[  FAILED  ] LayerTreeHostTestBreakSwapPromise.RunMultiThread_DelegatingRenderer_ImplSidePaint (3 ms)

We have a EXPECT_TRUE on the SwapPromise's dtor to be called which passes.
It means we destroyed the SwapPromise without ever breaking them first
(no DidNotSwap ever called). I checked all the code path where we destroy
SwapPromise and we always break them first. So I can't figure out why it
is the case. I am adding some logging information and turn this test back
on, hopefully next time it fails on the bot I can use the extra logging
information to debug.

BUG=393995
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289679

[danakj, 2014-08-13 23:09:07]

LGTM

https://codereview.chromium.org/477443002/diff/1/cc/trees/layer_tree_host_uni...
File cc/trees/layer_tree_host_unittest.cc (right):

https://codereview.chromium.org/477443002/diff/1/cc/trees/layer_tree_host_uni...
cc/trees/layer_tree_host_unittest.cc:4471: LOG(INFO) << "~TestSwapPromise() "
i suggest LOG(ERROR), maybe this works too but i've always used ERROR.

[Yufeng Shen (Slow to review), 2014-08-13 23:25:58]

https://codereview.chromium.org/477443002/diff/1/cc/trees/layer_tree_host_uni...
File cc/trees/layer_tree_host_unittest.cc (right):

https://codereview.chromium.org/477443002/diff/1/cc/trees/layer_tree_host_uni...
cc/trees/layer_tree_host_unittest.cc:4471: LOG(INFO) << "~TestSwapPromise() "
On 2014/08/13 23:09:07, danakj wrote:
> i suggest LOG(ERROR), maybe this works too but i've always used ERROR.

Done.

[Yufeng Shen (Slow to review), 2014-08-13 23:26:01]

The CQ bit was checked by miletus@chromium.org

[commit-bot: I haz the power, 2014-08-13 23:30:03]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/miletus@chromium.org/477443002/20001

[commit-bot: I haz the power, 2014-08-14 05:36:41]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/41554)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/46770)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg/bui...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-14 05:41:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-14 05:41:57]

Try jobs failed on following builders:
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/41605)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Yufeng Shen (Slow to review), 2014-08-14 15:18:37]

The CQ bit was checked by miletus@chromium.org

[commit-bot: I haz the power, 2014-08-14 15:22:05]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/miletus@chromium.org/477443002/20001

[commit-bot: I haz the power, 2014-08-14 19:50:14]

Committed patchset #2 (20001) as 289679