Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1165)

Unified Diff: sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart

Issue 47743011: Substitute types in generic superclasses and interfaces. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed comments. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart
diff --git a/sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart b/sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart
index 8466c633060bb2fb8bd425252a7ed1a76358e604..b8c46e9590cd0702c2fecb8f3f1d84dea43dd926 100644
--- a/sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart
+++ b/sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart
@@ -354,11 +354,15 @@ class ClassEmitter extends CodeEmitterHelper {
if (!backend.isNeededForReflection(classElement)) {
buffer.write(',$n$n"+$reflectionName": 0');
} else {
- List<int> interfaces = <int>[];
+ List<int> types = <int>[];
+ if (classElement.supertype != null) {
+ types.add(
+ task.metadataEmitter.reifyType(classElement.supertype));
+ }
for (DartType interface in classElement.interfaces) {
- interfaces.add(task.metadataEmitter.reifyType(interface));
+ types.add(task.metadataEmitter.reifyType(interface));
}
- buffer.write(',$n$n"+$reflectionName": $interfaces');
+ buffer.write(',$n$n"+$reflectionName": $types');
}
}
}

Powered by Google App Engine
This is Rietveld 408576698