Add a basic test for GL_CHROMIUM_framebuffer_multisample

Add a basic test for GL_CHROMIUM_framebuffer_multisample

BUG=285066
NOTRY=True

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231615

[no sievers, 2013-10-28 19:01:24]

ptal

[Sami, 2013-10-29 16:31:16]

lgtm, neat test!

https://codereview.chromium.org/47743008/diff/50001/gpu/command_buffer/tests/...
File gpu/command_buffer/tests/gl_chromium_framebuffer_multisample_unittest.cc
(right):

https://codereview.chromium.org/47743008/diff/50001/gpu/command_buffer/tests/...
gpu/command_buffer/tests/gl_chromium_framebuffer_multisample_unittest.cc:114:
glTexParameterf(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_LINEAR);
Pet peeve: glTexParameteri :)

https://codereview.chromium.org/47743008/diff/50001/gpu/command_buffer/tests/...
gpu/command_buffer/tests/gl_chromium_framebuffer_multisample_unittest.cc:155:
EXPECT_TRUE(GLTestHelper::CheckPixels(0, height - 1, 1, 1, 0, green));
I wonder if this part could be a little flaky since you're checking at the very
corner of the viewport which is also at the edge of the triangle. Some MSAA
sample configuration could result in low order bit noise here. To be safer I'd
move these a little closer to the center.

[no sievers, 2013-10-29 18:45:47]

https://codereview.chromium.org/47743008/diff/50001/gpu/command_buffer/tests/...
File gpu/command_buffer/tests/gl_chromium_framebuffer_multisample_unittest.cc
(right):

https://codereview.chromium.org/47743008/diff/50001/gpu/command_buffer/tests/...
gpu/command_buffer/tests/gl_chromium_framebuffer_multisample_unittest.cc:114:
glTexParameterf(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_LINEAR);
On 2013/10/29 16:31:16, Sami wrote:
> Pet peeve: glTexParameteri :)

Done.

https://codereview.chromium.org/47743008/diff/50001/gpu/command_buffer/tests/...
gpu/command_buffer/tests/gl_chromium_framebuffer_multisample_unittest.cc:155:
EXPECT_TRUE(GLTestHelper::CheckPixels(0, height - 1, 1, 1, 0, green));
On 2013/10/29 16:31:16, Sami wrote:
> I wonder if this part could be a little flaky since you're checking at the
very
> corner of the viewport which is also at the edge of the triangle. Some MSAA
> sample configuration could result in low order bit noise here. To be safer I'd
> move these a little closer to the center.

Done.

[commit-bot: I haz the power, 2013-10-29 19:14:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sievers@chromium.org/47743008/150001

[commit-bot: I haz the power, 2013-10-29 19:33:47]

Change committed as 231615