Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(822)

Issue 47743007: Avoid using dd() in Prologue when --optimize-for-size. (Closed)

Created:
7 years, 1 month ago by rmcilroy
Modified:
7 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Visibility:
Public.

Description

Avoid using dd() in Prologue when --optimize-for-size. When --optimize-for-size is true, the prologue generation outputs the pre-aging code stub address directly to the instruction stream. Previously this was done using dd() which failed if there was any pending constant pool entries left to be written. This CL introduces an emit_code_stub_address() for this purpose instead. BUG=v8:2968 R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17485

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
M src/arm/assembler-arm.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/arm/assembler-arm.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/arm/codegen-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
rmcilroy
PTAL.
7 years, 1 month ago (2013-10-28 18:12:08 UTC) #1
Benedikt Meurer
On 2013/10/28 18:12:08, rmcilroy wrote: > PTAL. LGTM
7 years, 1 month ago (2013-10-31 10:23:43 UTC) #2
Michael Achenbach
7 years, 1 month ago (2013-11-05 13:19:25 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r17485 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698