Issue 477353002: Add on_demand_service_tool

Issue 477353002: Add on_demand_service_tool (Closed)

Created:
6 years, 4 months ago by Mark Mentovai

Modified:
6 years, 4 months ago

Reviewers:
Robert Sesek

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Project:
crashpad

Visibility:
Public.

More Reviews

Description

Add on_demand_service_tool. R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/0b7f86a650be

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address review feedback #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+341 lines, -0 lines)			Patch
M	crashpad.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	tools/on_demand_service_tool.mm	View	1	1 chunk	+192 lines, -0 lines	0 comments	Download
A	tools/tool_support.h	View		1 chunk	+49 lines, -0 lines	0 comments	Download
A	tools/tool_support.cc	View		1 chunk	+51 lines, -0 lines	0 comments	Download
A	tools/tools.gyp	View	1	1 chunk	+48 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Robert Sesek

This is the nicest usage of getopt I've read in a long time (ever?). https://codereview.chromium.org/477353002/diff/1/tools/on_demand_service_tool.mm ...

6 years, 4 months ago (2014-08-20 18:16:07 UTC) #2

Mark Mentovai

rsesek wrote: > This is the nicest usage of getopt I've read in a long ...

6 years, 4 months ago (2014-08-20 18:25:27 UTC) #3

Mark Mentovai

6 years, 4 months ago (2014-08-20 19:19:02 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as 0b7f86a650be (presubmit successful).

Expand Messages | Collapse Messages